Sign upLogin

whiteCube/lingua

View on GitHub
Star
src/Lingua/LanguagesRepository.php

Summary

Maintainability
A
1 hr
Test Coverage

Function find has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static function find($format, $value)
    {
        $instance = self::getInstance();
        foreach ($instance->languages as $language) {
            if(!isset($language[$format])) continue;
Severity: Minor
Found in src/Lingua/LanguagesRepository.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '60', column '23').
Open

            throw new \Exception('Lingua\'s languages repository could not be loaded');
Severity: Minor
Found in src/Lingua/LanguagesRepository.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 59.
Open

    protected function loadRepository()
    {
        if(false === @file_get_contents($this->path)) {
            throw new \Exception('Lingua\'s languages repository could not be loaded');
        }
Severity: Minor
Found in src/Lingua/LanguagesRepository.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

There are no issues that match your filters.

Category
Status