whitequark/parser

View on GitHub
lib/parser/source/rewriter.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Rewriter has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Rewriter
      attr_reader :source_buffer
      attr_reader :diagnostics

      ##
Severity: Minor
Found in lib/parser/source/rewriter.rb - About 4 hrs to fix

    Method append has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

          def append(action)
            range = action.range
    
            # Is this an insertion?
            if range.empty?
    Severity: Minor
    Found in lib/parser/source/rewriter.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File rewriter.rb has 263 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Parser
      module Source
    
        ##
        # {Rewriter} is deprecated. Use {TreeRewriter} instead.
    Severity: Minor
    Found in lib/parser/source/rewriter.rb - About 2 hrs to fix

      Method append has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def append(action)
              range = action.range
      
              # Is this an insertion?
              if range.empty?
      Severity: Minor
      Found in lib/parser/source/rewriter.rb - About 1 hr to fix

        Method merge_replacements has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def merge_replacements(actions)
                result    = ''.dup
                prev_act  = nil
        
                actions.each do |act|
        Severity: Minor
        Found in lib/parser/source/rewriter.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status