Sign upLogin

whitesharx/httx

View on GitHub
Star

Showing 5 of 150 total issues

Method UnsafeCompleteEdit has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

    [MethodImpl(MethodImplOptions.Synchronized)]
    public void UnsafeCompleteEdit(Editor editor, bool success) {
      var entry = editor.Entry;

      if (entry.UnsafeCurrentEditor != editor) {
Severity: Minor
Found in Assets/Httx/Runtime/Caches/Disk/DiskLruCache.cs - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method UnsafeCompleteEdit has 52 lines of code (exceeds 50 allowed). Consider refactoring.
Open

    [MethodImpl(MethodImplOptions.Synchronized)]
    public void UnsafeCompleteEdit(Editor editor, bool success) {
      var entry = editor.Entry;

      if (entry.UnsafeCurrentEditor != editor) {
Severity: Major
Found in Assets/Httx/Runtime/Caches/Disk/DiskLruCache.cs - About 1 hr to fix

    Method InitializeDefault has 51 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

        public static void InitializeDefault(int version, Action onContextReady,
      Action<Builder> onBeforeInstantiate = null, int inflateMultiplier = 1) {

      var memoryMaxSize = inflateMultiplier * MemoryMaxSize;
      var diskMaxSize = inflateMultiplier * DiskMaxSize;
    Severity: Major
    Found in Assets/Httx/Runtime/Context.cs - About 1 hr to fix

      Method Open has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static DiskLruCache Open(DirectoryInfo directory, int appVersion, int valueCount, long maxSize,
        int compactThreshold = 2000) {
      Severity: Minor
      Found in Assets/Httx/Runtime/Caches/Disk/DiskLruCache.cs - About 35 mins to fix

        Avoid too many return statements within this method.
        Open

              return new AsyncOperationQueue(tryHitCache, netRequest, tryPutCache);
        Severity: Major
        Found in Assets/Httx/Runtime/Requests/Awaiters/BaseUnityAwaiter.cs - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language