Sign upLogin

whitesharx/httx

View on GitHub
Star

Showing 149 of 150 total issues

Method UnsafeCompleteEdit has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

    [MethodImpl(MethodImplOptions.Synchronized)]
    public void UnsafeCompleteEdit(Editor editor, bool success) {
      var entry = editor.Entry;

      if (entry.UnsafeCurrentEditor != editor) {
Severity: Minor
Found in Assets/Httx/Runtime/Caches/Disk/DiskLruCache.cs - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static void CallOnOnResponseReceived(this IRequest request, UnityWebRequest unityWebRequest) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var callbackObject = headers.FetchHeader<Callback<UnityWebRequest>>(InternalHeaders.HookObject);

      callbackObject?.OnResponseReceived?.Invoke(unityWebRequest);
Severity: Major
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 1 hr to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 180..185

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static void CallOnBeforeRequestSent(this IRequest request, UnityWebRequest unityWebRequest) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var callbackObject = headers.FetchHeader<Callback<UnityWebRequest>>(InternalHeaders.HookObject);

      callbackObject?.OnBeforeRequestSent?.Invoke(unityWebRequest);
Severity: Major
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 1 hr to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 187..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method UnsafeCompleteEdit has 52 lines of code (exceeds 50 allowed). Consider refactoring.
Open

    [MethodImpl(MethodImplOptions.Synchronized)]
    public void UnsafeCompleteEdit(Editor editor, bool success) {
      var entry = editor.Entry;

      if (entry.UnsafeCurrentEditor != editor) {
Severity: Major
Found in Assets/Httx/Runtime/Caches/Disk/DiskLruCache.cs - About 1 hr to fix

    Method InitializeDefault has 51 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

        public static void InitializeDefault(int version, Action onContextReady,
      Action<Builder> onBeforeInstantiate = null, int inflateMultiplier = 1) {

      var memoryMaxSize = inflateMultiplier * MemoryMaxSize;
      var diskMaxSize = inflateMultiplier * DiskMaxSize;
    Severity: Major
    Found in Assets/Httx/Runtime/Context.cs - About 1 hr to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      using System;
using UnityEngine.Networking;

namespace Httx.Requests.Verbs {
  public class Create : Verb {
      Severity: Major
      Found in Assets/Httx/Runtime/Requests/Verbs/Create.cs and 4 other locations - About 55 mins to fix
      Assets/Httx/Runtime/Requests/Verbs/Delete.cs on lines 21..35
      Assets/Httx/Runtime/Requests/Verbs/Get.cs on lines 21..34
      Assets/Httx/Runtime/Requests/Verbs/Post.cs on lines 21..34
      Assets/Httx/Runtime/Requests/Verbs/Put.cs on lines 21..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 87.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      using System;
using UnityEngine.Networking;

namespace Httx.Requests.Verbs {
  public class Delete : Verb {
      Severity: Major
      Found in Assets/Httx/Runtime/Requests/Verbs/Delete.cs and 4 other locations - About 55 mins to fix
      Assets/Httx/Runtime/Requests/Verbs/Create.cs on lines 21..35
      Assets/Httx/Runtime/Requests/Verbs/Get.cs on lines 21..34
      Assets/Httx/Runtime/Requests/Verbs/Post.cs on lines 21..34
      Assets/Httx/Runtime/Requests/Verbs/Put.cs on lines 21..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 87.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      using System;
using UnityEngine.Networking;

namespace Httx.Requests.Verbs {
  public class Post : Verb {
      Severity: Major
      Found in Assets/Httx/Runtime/Requests/Verbs/Post.cs and 4 other locations - About 55 mins to fix
      Assets/Httx/Runtime/Requests/Verbs/Create.cs on lines 21..35
      Assets/Httx/Runtime/Requests/Verbs/Delete.cs on lines 21..35
      Assets/Httx/Runtime/Requests/Verbs/Get.cs on lines 21..34
      Assets/Httx/Runtime/Requests/Verbs/Put.cs on lines 21..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 87.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      using System;
using UnityEngine.Networking;

namespace Httx.Requests.Verbs {
  public class Put : Verb {
      Severity: Major
      Found in Assets/Httx/Runtime/Requests/Verbs/Put.cs and 4 other locations - About 55 mins to fix
      Assets/Httx/Runtime/Requests/Verbs/Create.cs on lines 21..35
      Assets/Httx/Runtime/Requests/Verbs/Delete.cs on lines 21..35
      Assets/Httx/Runtime/Requests/Verbs/Get.cs on lines 21..34
      Assets/Httx/Runtime/Requests/Verbs/Post.cs on lines 21..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 87.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      using System;
using UnityEngine.Networking;

namespace Httx.Requests.Verbs {
  public class Get : Verb {
      Severity: Major
      Found in Assets/Httx/Runtime/Requests/Verbs/Get.cs and 4 other locations - About 55 mins to fix
      Assets/Httx/Runtime/Requests/Verbs/Create.cs on lines 21..35
      Assets/Httx/Runtime/Requests/Verbs/Delete.cs on lines 21..35
      Assets/Httx/Runtime/Requests/Verbs/Post.cs on lines 21..34
      Assets/Httx/Runtime/Requests/Verbs/Put.cs on lines 21..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 87.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public override IEnumerable<KeyValuePair<string, object>> Headers {
      get {
        var headers = new Dictionary<string, object> {
            { "Accept", "application/json;charset=UTF-8" }
        };
      Severity: Major
      Found in Assets/Httx/Runtime/Requests/Types/Json.cs and 2 other locations - About 50 mins to fix
      Assets/Httx/Runtime/Requests/Types/Bytes.cs on lines 34..46
      Assets/Httx/Runtime/Requests/Types/Text.cs on lines 20..32

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public override IEnumerable<KeyValuePair<string, object>> Headers {
      get {
        var headers = new Dictionary<string, object> {
            { "Accept", "application/octet-stream" }
        };
      Severity: Major
      Found in Assets/Httx/Runtime/Requests/Types/Bytes.cs and 2 other locations - About 50 mins to fix
      Assets/Httx/Runtime/Requests/Types/Json.cs on lines 27..39
      Assets/Httx/Runtime/Requests/Types/Text.cs on lines 20..32

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public override IEnumerable<KeyValuePair<string, object>> Headers {
      get {
        var headers = new Dictionary<string, object> {
            { "Accept", "text/plain;charset=UTF-8" }
        };
      Severity: Major
      Found in Assets/Httx/Runtime/Requests/Types/Text.cs and 2 other locations - About 50 mins to fix
      Assets/Httx/Runtime/Requests/Types/Bytes.cs on lines 34..46
      Assets/Httx/Runtime/Requests/Types/Json.cs on lines 27..39

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public IAsyncOperation Lock(string requestUrl) {
      var operation = new MutableAsyncOperation();

      LockImpl(requestUrl, editor => {
        operation.Progress = 1.0f;
      Severity: Minor
      Found in Assets/Httx/Runtime/Caches/DiskCache.cs and 1 other location - About 50 mins to fix
      Assets/Httx/Runtime/Caches/DiskCache.cs on lines 78..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static bool IsMemoryCacheEnabled(this IRequest request) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var isEnabled = headers.FetchHeader<bool>(InternalHeaders.MemoryCacheEnabled);

      return isEnabled;
      Severity: Minor
      Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 50 mins to fix
      Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 159..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static int FetchCacheItemMaxAge(this IRequest request) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var maxAge = headers.FetchHeader<int>(InternalHeaders.CacheItemMaxAge);

      return maxAge;
      Severity: Minor
      Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 50 mins to fix
      Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 152..157

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public IAsyncOperation Get(string requestUrl) {
      var operation = new MutableAsyncOperation();

      GetImpl(requestUrl, cachedFileUrl => {
        operation.Progress = 1.0f;
      Severity: Minor
      Found in Assets/Httx/Runtime/Caches/DiskCache.cs and 1 other location - About 50 mins to fix
      Assets/Httx/Runtime/Caches/DiskCache.cs on lines 92..104

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static Condition FetchConditionObject(this IRequest request) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var condition = headers.FetchHeader<Condition>(InternalHeaders.ConditionObject);

      return condition;
      Severity: Minor
      Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 50 mins to fix
      Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 166..171

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static CancellationToken FetchCancelToken(this IRequest request) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var token = headers.FetchHeader<CancellationToken>(InternalHeaders.CancelToken);

      return token;
      Severity: Minor
      Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 50 mins to fix
      Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 173..178

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method Open has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static DiskLruCache Open(DirectoryInfo directory, int appVersion, int valueCount, long maxSize,
        int compactThreshold = 2000) {
      Severity: Minor
      Found in Assets/Httx/Runtime/Caches/Disk/DiskLruCache.cs - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language