Sign upLogin

whotwagner/suricata

View on GitHub
Star

Showing 4 of 4 total issues

Method search has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def search(str)
    @search_str = str
    @found_str = nil

    if @fast.nil?
Severity: Minor
Found in lib/suricata/nagios.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method runApp has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def runApp(args)
    help = nil
    interactive = false

    OptionParser.new do |opt|
Severity: Minor
Found in lib/suricata/nagios.rb - About 1 hr to fix

    Method acknowlege has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def acknowlege(str)

    if @fast.nil?
        init_log
    end
    Severity: Minor
    Found in lib/suricata/nagios.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def parse(string)
    if string.nil?
        raise "Invalid argument"
    end
    Severity: Minor
    Found in lib/suricata/fast.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language