Sign upLogin

whylabs/whylogs-python

View on GitHub
Star
java/core/src/main/java/com/whylogs/core/DatasetProfile.java

Summary

Maintainability
A
35 mins
Test Coverage

Method doTrack has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  private void doTrack(HashMap<String, ?> row) {
    boolean dirty = this.schema.resolve(row);
    if (dirty) {
      Set<String> schemaColumnNames = this.schema.getColNames();
      Set<String> newColumnNames = new HashSet<>();
Severity: Minor
Found in java/core/src/main/java/com/whylogs/core/DatasetProfile.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

  // TODO: I don't like how this works for customers. I wouldn't want
Severity: Minor
Found in java/core/src/main/java/com/whylogs/core/DatasetProfile.java by fixme

TODO found
Open

  // TODO: to have to pass the optionals around. We should just use overloading instead
Severity: Minor
Found in java/core/src/main/java/com/whylogs/core/DatasetProfile.java by fixme

TODO found
Open

      // TODO: log warning if it's not there
Severity: Minor
Found in java/core/src/main/java/com/whylogs/core/DatasetProfile.java by fixme

TODO found
Open

// TODO: extend WRITABLE interface
Severity: Minor
Found in java/core/src/main/java/com/whylogs/core/DatasetProfile.java by fixme

There are no issues that match your filters.

Category
Status