Sign upLogin

widmogrod/php-functional

View on GitHub
Star
src/Functional/functions.php

Summary

Maintainability
A
0 mins
Test Coverage
A
92%

File functions.php has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

<?php

declare(strict_types=1);

namespace Widmogrod\Functional;
Severity: Minor
Found in src/Functional/functions.php - About 2 hrs to fix

    Missing class import via use statement (line '86', column '33').
    Open

        $reflectionOfFunction = new \ReflectionFunction(\Closure::fromCallable($function));
    Severity: Minor
    Found in src/Functional/functions.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method foldM uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                return $k->bind(function ($z) use ($f, $x) {
                    return $f($z, $x);
                });
            }
    Severity: Minor
    Found in src/Functional/functions.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    There are no issues that match your filters.

    Category
    Status