Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Html/Html.php

Summary

Maintainability
F
1 wk
Test Coverage

File Html.php has 598 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Collection of methods to generate HTML content
 *
 * Copyright © 2009 Aryeh Gregor
Severity: Major
Found in includes/Html/Html.php - About 1 day to fix

    Function expandAttributes has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function expandAttributes( array $attribs ) {
        $ret = '';
        foreach ( $attribs as $key => $value ) {
            // Support intuitive [ 'checked' => true/false ] form
            if ( $value === false || $value === null ) {
    Severity: Minor
    Found in includes/Html/Html.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function dropDefaults has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function dropDefaults( $element, array $attribs ) {
        // Whenever altering this array, please provide a covering test case
        // in HtmlTest::provideElementsWithAttributesHavingDefaultValues
        static $attribDefaults = [
            'area' => [ 'shape' => 'rect' ],
    Severity: Minor
    Found in includes/Html/Html.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Html has 35 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Html {
    /** @var bool[] List of void elements from HTML5, section 8.1.2 as of 2016-09-19 */
    private static $voidElements = [
        'area' => true,
        'base' => true,
    Severity: Minor
    Found in includes/Html/Html.php - About 4 hrs to fix

      Method dropDefaults has 78 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static function dropDefaults( $element, array $attribs ) {
        // Whenever altering this array, please provide a covering test case
        // in HtmlTest::provideElementsWithAttributesHavingDefaultValues
        static $attribDefaults = [
            'area' => [ 'shape' => 'rect' ],
      Severity: Major
      Found in includes/Html/Html.php - About 3 hrs to fix

        Function listDropdownOptions has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function listDropdownOptions( $list, $params = [] ) {
        $options = [];

        if ( isset( $params['other'] ) ) {
            $options[ $params['other'] ] = 'other';
        Severity: Minor
        Found in includes/Html/Html.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method expandAttributes has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function expandAttributes( array $attribs ) {
        $ret = '';
        foreach ( $attribs as $key => $value ) {
            // Support intuitive [ 'checked' => true/false ] form
            if ( $value === false || $value === null ) {
        Severity: Major
        Found in includes/Html/Html.php - About 2 hrs to fix

          Method openElement has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function openElement( $element, $attribs = [] ) {
        $attribs = (array)$attribs;
        // This is not required in HTML5, but let's do it anyway, for
        // consistency and better compression.
        $element = strtolower( $element );
          Severity: Minor
          Found in includes/Html/Html.php - About 1 hr to fix

            Method namespaceSelector has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function namespaceSelector(
        array $params = [],
        array $selectAttribs = []
    ) {
        ksort( $selectAttribs );
            Severity: Minor
            Found in includes/Html/Html.php - About 1 hr to fix

              Function namespaceSelectorOptions has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function namespaceSelectorOptions( array $params = [] ) {
        if ( !isset( $params['exclude'] ) || !is_array( $params['exclude'] ) ) {
            $params['exclude'] = [];
        }
              Severity: Minor
              Found in includes/Html/Html.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method listDropdownOptions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function listDropdownOptions( $list, $params = [] ) {
        $options = [];

        if ( isset( $params['other'] ) ) {
            $options[ $params['other'] ] = 'other';
              Severity: Minor
              Found in includes/Html/Html.php - About 1 hr to fix

                Method namespaceSelectorOptions has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function namespaceSelectorOptions( array $params = [] ) {
        if ( !isset( $params['exclude'] ) || !is_array( $params['exclude'] ) ) {
            $params['exclude'] = [];
        }
                Severity: Minor
                Found in includes/Html/Html.php - About 1 hr to fix

                  Function namespaceSelector has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function namespaceSelector(
        array $params = [],
        array $selectAttribs = []
    ) {
        ksort( $selectAttribs );
                  Severity: Minor
                  Found in includes/Html/Html.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function openElement has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function openElement( $element, $attribs = [] ) {
        $attribs = (array)$attribs;
        // This is not required in HTML5, but let's do it anyway, for
        // consistency and better compression.
        $element = strtolower( $element );
                  Severity: Minor
                  Found in includes/Html/Html.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function listDropdownOptionsOoui has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function listDropdownOptionsOoui( $options ) {
        $optionsOoui = [];

        foreach ( $options as $text => $value ) {
            if ( is_array( $value ) ) {
                  Severity: Minor
                  Found in includes/Html/Html.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public static function listDropdownOptions( $list, $params = [] ) {
        $options = [];

        if ( isset( $params['other'] ) ) {
            $options[ $params['other'] ] = 'other';
                  Severity: Major
                  Found in includes/Html/Html.php and 1 other location - About 1 day to fix
                  includes/xml/Xml.php on lines 550..590

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 332.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                              $validTypes = [
                'hidden' => true,
                'text' => true,
                'password' => true,
                'checkbox' => true,
                  Severity: Major
                  Found in includes/Html/Html.php and 4 other locations - About 5 hrs to fix
                  languages/messages/MessagesAs.php on lines 27..51
                  languages/messages/MessagesDiq.php on lines 27..51
                  languages/messages/MessagesFf.php on lines 12..37
                  languages/messages/MessagesMhr.php on lines 35..62

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 192.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public static function listDropdownOptionsOoui( $options ) {
        $optionsOoui = [];

        foreach ( $options as $text => $value ) {
            if ( is_array( $value ) ) {
                  Severity: Major
                  Found in includes/Html/Html.php and 1 other location - About 1 hr to fix
                  includes/xml/Xml.php on lines 600..615

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 115.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public static function check( $name, $checked = false, array $attribs = [] ) {
        if ( isset( $attribs['value'] ) ) {
            $value = $attribs['value'];
            unset( $attribs['value'] );
        } else {
                  Severity: Minor
                  Found in includes/Html/Html.php and 1 other location - About 45 mins to fix
                  includes/Html/Html.php on lines 799..812

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 96.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public static function radio( $name, $checked = false, array $attribs = [] ) {
        if ( isset( $attribs['value'] ) ) {
            $value = $attribs['value'];
            unset( $attribs['value'] );
        } else {
                  Severity: Minor
                  Found in includes/Html/Html.php and 1 other location - About 45 mins to fix
                  includes/Html/Html.php on lines 679..692

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 96.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status