Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/MediaWikiServices.php

Summary

Maintainability
F
1 wk
Test Coverage

MediaWikiServices has 220 functions (exceeds 20 allowed). Consider refactoring.
Open

class MediaWikiServices extends ServiceContainer {
    use NonSerializableTrait;

    /**
     * @var bool
Severity: Major
Found in includes/MediaWikiServices.php - About 4 days to fix

    File MediaWikiServices.php has 996 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Major
    Found in includes/MediaWikiServices.php - About 2 days to fix

      Method disableStorage has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function disableStorage() {
        if ( $this->storageDisabled ) {
            return;
        }
      Severity: Minor
      Found in includes/MediaWikiServices.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                        return new StaticUserOptionsLookup(
                    [],
                    $services->getMainConfig()->get( MainConfigNames::DefaultUserOptions )
                );
        Severity: Major
        Found in includes/MediaWikiServices.php - About 30 mins to fix

          Function salvage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function salvage( self $other ) {
        foreach ( $this->getServiceNames() as $name ) {
            // The service could be new in the new instance and not registered in the
            // other instance (e.g. an extension that was loaded after the instantiation of
            // the other instance. Skip this service in this case. See T143974
          Severity: Minor
          Found in includes/MediaWikiServices.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status