Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Navigation/PagerNavigationBuilder.php

Summary

Maintainability
B
5 hrs
Test Coverage

PagerNavigationBuilder has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class PagerNavigationBuilder {
    /** @var MessageLocalizer */
    private $messageLocalizer;

    /** @var PageReference */
Severity: Minor
Found in includes/Navigation/PagerNavigationBuilder.php - About 2 hrs to fix

    Method getHtml has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getHtml(): string {
        if ( !isset( $this->page ) ) {
            throw new RuntimeException( 'page must be set' );
        }
        if ( isset( $this->firstMsg ) !== isset( $this->lastMsg ) ) {
    Severity: Major
    Found in includes/Navigation/PagerNavigationBuilder.php - About 2 hrs to fix

      Method makeLink has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ?array $query, ?string $class, string $text, ?string $tooltip, ?string $rel = null
      Severity: Minor
      Found in includes/Navigation/PagerNavigationBuilder.php - About 35 mins to fix

        Function getHtml has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getHtml(): string {
        if ( !isset( $this->page ) ) {
            throw new RuntimeException( 'page must be set' );
        }
        if ( isset( $this->firstMsg ) !== isset( $this->lastMsg ) ) {
        Severity: Minor
        Found in includes/Navigation/PagerNavigationBuilder.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status