Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Output/OutputHandler.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method handleGzip has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function handleGzip( $s ) {
        if ( !function_exists( 'gzencode' ) ) {
            wfDebug( __METHOD__ . "() skipping compression (gzencode unavailable)" );
            return $s;
        }
Severity: Minor
Found in includes/Output/OutputHandler.php - About 1 hr to fix

    Method handle has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function handle( $s, $phase ) {
        $config = MediaWikiServices::getInstance()->getMainConfig();
        $disableOutputCompression = $config->get( MainConfigNames::DisableOutputCompression );
        // Don't send headers if output is being discarded (T278579)
        if ( ( $phase & PHP_OUTPUT_HANDLER_CLEAN ) === PHP_OUTPUT_HANDLER_CLEAN ) {
    Severity: Minor
    Found in includes/Output/OutputHandler.php - About 1 hr to fix

      Function handleGzip has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function handleGzip( $s ) {
        if ( !function_exists( 'gzencode' ) ) {
            wfDebug( __METHOD__ . "() skipping compression (gzencode unavailable)" );
            return $s;
        }
      Severity: Minor
      Found in includes/Output/OutputHandler.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $s;
      Severity: Major
      Found in includes/Output/OutputHandler.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status