Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Output/StreamFile.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method contentTypeFromPath has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function contentTypeFromPath( $filename, $safe = true ) {
        // NOTE: TrivialMimeDetection is forced by ThumbnailEntryPoint. When this
        // code is moved to a non-static method in a service object, we can no
        // longer rely on that.
        $trivialMimeDetection = MediaWikiServices::getInstance()->getMainConfig()
Severity: Minor
Found in includes/Output/StreamFile.php - About 1 hr to fix

    Function contentTypeFromPath has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function contentTypeFromPath( $filename, $safe = true ) {
        // NOTE: TrivialMimeDetection is forced by ThumbnailEntryPoint. When this
        // code is moved to a non-static method in a service object, we can no
        // longer rely on that.
        $trivialMimeDetection = MediaWikiServices::getInstance()->getMainConfig()
    Severity: Minor
    Found in includes/Output/StreamFile.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method stream has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $fname,
        $headers = [],
        $sendErrors = true,
        $optHeaders = [],
        $flags = 0
    Severity: Minor
    Found in includes/Output/StreamFile.php - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

                      return self::UNKNOWN_CONTENT_TYPE;
      Severity: Major
      Found in includes/Output/StreamFile.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return $type;
        Severity: Major
        Found in includes/Output/StreamFile.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return self::UNKNOWN_CONTENT_TYPE;
          Severity: Major
          Found in includes/Output/StreamFile.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return self::UNKNOWN_CONTENT_TYPE;
            Severity: Major
            Found in includes/Output/StreamFile.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status