wikimedia/mediawiki-core

View on GitHub
includes/Permissions/UserAuthority.php

Summary

Maintainability
C
1 day
Test Coverage

File UserAuthority.php has 277 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/Permissions/UserAuthority.php - About 2 hrs to fix

    Function internalCan has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        private function internalCan(
            string $rigor,
            string $action,
            PageIdentity $target,
            ?PermissionStatus $status,
    Severity: Minor
    Found in includes/Permissions/UserAuthority.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function internalAllowed has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        private function internalAllowed(
            string $action,
            ?PermissionStatus $status,
            $limitRate,
            ?Block $userBlock
    Severity: Minor
    Found in includes/Permissions/UserAuthority.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method internalAllowed has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function internalAllowed(
            string $action,
            ?PermissionStatus $status,
            $limitRate,
            ?Block $userBlock
    Severity: Minor
    Found in includes/Permissions/UserAuthority.php - About 1 hr to fix

      Method internalCan has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function internalCan(
              string $rigor,
              string $action,
              PageIdentity $target,
              ?PermissionStatus $status,
      Severity: Minor
      Found in includes/Permissions/UserAuthority.php - About 1 hr to fix

        Function limit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function limit( string $action, int $incrBy, ?PermissionStatus $status ): bool {
                $isLimited = null;
        
                if ( $this->useLimitCache && isset( $this->limitCache[ $action ] ) ) {
                    // subtract the increment that was already applied earlier
        Severity: Minor
        Found in includes/Permissions/UserAuthority.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                User $user,
                WebRequest $request,
                IContextSource $uiContext,
                PermissionManager $permissionManager,
                RateLimiter $rateLimiter,
        Severity: Minor
        Found in includes/Permissions/UserAuthority.php - About 45 mins to fix

          Method internalCan has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  string $rigor,
                  string $action,
                  PageIdentity $target,
                  ?PermissionStatus $status,
                  $limitRate
          Severity: Minor
          Found in includes/Permissions/UserAuthority.php - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status