Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/RenameUser/RenameuserSQL.php

Summary

Maintainability
C
1 day
Test Coverage

Method rename has 143 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function rename() {
        $dbw = $this->dbProvider->getPrimaryDatabase();
        $atomicId = $dbw->startAtomic( __METHOD__, $dbw::ATOMIC_CANCELABLE );

        $this->hookRunner->onRenameUserPreRename( $this->uid, $this->old, $this->new );
Severity: Major
Found in includes/RenameUser/RenameuserSQL.php - About 5 hrs to fix

    Function rename has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        public function rename() {
        $dbw = $this->dbProvider->getPrimaryDatabase();
        $atomicId = $dbw->startAtomic( __METHOD__, $dbw::ATOMIC_CANCELABLE );

        $this->hookRunner->onRenameUserPreRename( $this->uid, $this->old, $this->new );
    Severity: Minor
    Found in includes/RenameUser/RenameuserSQL.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct( $old, $new, $uid, User $renamer, $options = [] ) {
        $services = MediaWikiServices::getInstance();
        $this->hookRunner = new HookRunner( $services->getHookContainer() );
        $this->dbProvider = $services->getConnectionProvider();
        $this->userFactory = $services->getUserFactory();
    Severity: Minor
    Found in includes/RenameUser/RenameuserSQL.php - About 1 hr to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct( $old, $new, $uid, User $renamer, $options = [] ) {
      Severity: Minor
      Found in includes/RenameUser/RenameuserSQL.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status