Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/ResourceLoader/ImageModule.php

Summary

Maintainability
C
1 day
Test Coverage

Function loadFromDefinition has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    protected function loadFromDefinition() {
        if ( $this->definition === null ) {
            return;
        }
Severity: Minor
Found in includes/ResourceLoader/ImageModule.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadFromDefinition has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function loadFromDefinition() {
        if ( $this->definition === null ) {
            return;
        }
Severity: Major
Found in includes/ResourceLoader/ImageModule.php - About 2 hrs to fix

    File ImageModule.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/ResourceLoader/ImageModule.php - About 2 hrs to fix

      Method getImages has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getImages( Context $context ): array {
        $skin = $context->getSkin();
        if ( $this->imageObjects === null ) {
            $this->loadFromDefinition();
            $this->imageObjects = [];
      Severity: Minor
      Found in includes/ResourceLoader/ImageModule.php - About 1 hr to fix

        Method getStyles has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getStyles( Context $context ): array {
        $this->loadFromDefinition();

        // Build CSS rules
        $rules = [];
        Severity: Minor
        Found in includes/ResourceLoader/ImageModule.php - About 1 hr to fix

          Function getImages has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getImages( Context $context ): array {
        $skin = $context->getSkin();
        if ( $this->imageObjects === null ) {
            $this->loadFromDefinition();
            $this->imageObjects = [];
          Severity: Minor
          Found in includes/ResourceLoader/ImageModule.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getGlobalVariants has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getGlobalVariants( Context $context ): array {
        $skin = $context->getSkin();
        if ( $this->globalVariants === null ) {
            $this->loadFromDefinition();
            $this->globalVariants = [];
          Severity: Minor
          Found in includes/ResourceLoader/ImageModule.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status