includes/ResourceLoader/Module.php
Module
has 49 functions (exceeds 20 allowed). Consider refactoring. Open
Open
abstract class Module implements LoggerAwareInterface {
/** @var Config */
protected $config;
/** @var LoggerInterface */
protected $logger;
Function buildContent
has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring. Open
Open
final protected function buildContent( Context $context ) {
$statsFactory = MediaWikiServices::getInstance()->getStatsFactory();
$statStart = microtime( true );
// This MUST build both scripts and styles, regardless of whether $context->getOnly()
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File Module.php
has 409 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
Method buildContent
has 67 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
final protected function buildContent( Context $context ) {
$statsFactory = MediaWikiServices::getInstance()->getStatsFactory();
$statStart = microtime( true );
// This MUST build both scripts and styles, regardless of whether $context->getOnly()
Method validateScriptFile
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
protected function validateScriptFile( $fileName, $contents ) {
if ( !$this->getConfig()->get( MainConfigNames::ResourceLoaderValidateJS ) ) {
return $contents;
}
$cache = MediaWikiServices::getInstance()->getMainWANObjectCache();
Function getVersionHash
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
final public function getVersionHash( Context $context ) {
if ( $context->getDebug() ) {
// In debug mode, make uncached startup module extra fast by not computing any hashes.
// Server responses from load.php for individual modules already have no-cache so
// we don't need them. This also makes breakpoint debugging easier, as each module
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
Open
return $contents;