Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Rest/Handler/Helper/PageContentHelper.php

Summary

Maintainability
C
1 day
Test Coverage

File PageContentHelper.php has 297 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace MediaWiki\Rest\Handler\Helper;

use MediaWiki\ChangeTags\ChangeTagsStore;
Severity: Minor
Found in includes/Rest/Handler/Helper/PageContentHelper.php - About 3 hrs to fix

    PageContentHelper has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class PageContentHelper {

    /**
     * The maximum cache duration for page content.
     *
    Severity: Minor
    Found in includes/Rest/Handler/Helper/PageContentHelper.php - About 2 hrs to fix

      Method getContent has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getContent(): TextContent {
        $revision = $this->getTargetRevision();

        if ( !$revision ) {
            $titleText = $this->getTitleText() ?? '';
      Severity: Minor
      Found in includes/Rest/Handler/Helper/PageContentHelper.php - About 1 hr to fix

        Method constructRestbaseCompatibleMetadata has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function constructRestbaseCompatibleMetadata(): array {
        $revision = $this->getRevisionRecordForMetadata();

        $page = $revision->getPage();
        $title = $this->titleFactory->newFromPageIdentity( $page );
        Severity: Minor
        Found in includes/Rest/Handler/Helper/PageContentHelper.php - About 1 hr to fix

          Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  ServiceOptions $options,
        RevisionLookup $revisionLookup,
        TitleFormatter $titleFormatter,
        PageLookup $pageLookup,
        TitleFactory $titleFactory,
          Severity: Major
          Found in includes/Rest/Handler/Helper/PageContentHelper.php - About 50 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function __construct(
        ServiceOptions $options,
        RevisionLookup $revisionLookup,
        TitleFormatter $titleFormatter,
        PageLookup $pageLookup,
            Severity: Major
            Found in includes/Rest/Handler/Helper/PageContentHelper.php and 1 other location - About 1 hr to fix
            includes/cache/LinkBatchFactory.php on lines 71..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 116.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status