Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Rest/Handler/PageHistoryCountHandler.php

Summary

Maintainability
F
4 days
Test Coverage

File PageHistoryCountHandler.php has 486 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace MediaWiki\Rest\Handler;

use ChangeTags;
Severity: Minor
Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 7 hrs to fix

    Method getCount has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getCount( $type ) {
        $pageId = $this->getPage()->getId();
        switch ( $type ) {
            case 'anonymous':
                return $this->getCachedCount( $type,
    Severity: Major
    Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 3 hrs to fix

      PageHistoryCountHandler has 23 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class PageHistoryCountHandler extends SimpleHandler {

    /** The maximum number of counts to return per type of revision */
    private const COUNT_LIMITS = [
        'anonymous' => 10000,
      Severity: Minor
      Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 2 hrs to fix

        Method run has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run( $title, $type ) {
        $normalizedType = $this->normalizeType( $type );
        $this->validateParameterCombination( $normalizedType );
        $params = $this->getValidatedParams();
        $page = $this->getPage();
        Severity: Minor
        Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 1 hr to fix

          Method getCachedCount has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function getCachedCount( $type,
        callable $fetchCount
    ) {
        $pageId = $this->getPage()->getId();
        return $this->cache->getWithSetCallback(
          Severity: Minor
          Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 1 hr to fix

            Method getBotCount has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function getBotCount( $pageId, RevisionRecord $fromRev = null ) {
        $dbr = $this->dbProvider->getReplicaDatabase();

        $queryBuilder = $dbr->newSelectQueryBuilder()
            ->select( '1' )
            Severity: Minor
            Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 1 hr to fix

              Method getRevertedCount has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function getRevertedCount( $pageId, RevisionRecord $fromRev = null ) {
        $tagIds = [];

        foreach ( ChangeTags::REVERT_TAGS as $tagName ) {
            try {
              Severity: Minor
              Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 1 hr to fix

                Function validateParameterCombination has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function validateParameterCombination( $type ) {
        $params = $this->getValidatedParams();
        if ( !$params ) {
            return;
        }
                Severity: Minor
                Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        RevisionStore $revisionStore,
        NameTableStoreFactory $nameTableStoreFactory,
        GroupPermissionsLookup $groupPermissionsLookup,
        IConnectionProvider $dbProvider,
        WANObjectCache $cache,
                Severity: Major
                Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 50 mins to fix

                  Function getCount has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function getCount( $type ) {
        $pageId = $this->getPage()->getId();
        switch ( $type ) {
            case 'anonymous':
                return $this->getCachedCount( $type,
                  Severity: Minor
                  Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                                          return $this->getEditsCount( $pageId, $fromRev );
                  Severity: Major
                  Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $this->getCachedCount( $type,
                    function ( RevisionRecord $fromRev = null ) use ( $pageId ) {
                        return $this->getMinorCount( $pageId, $fromRev );
                    }
                );
                    Severity: Major
                    Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return $this->getEditsCount(
                        $pageId,
                        $from ? $this->getRevisionOrThrow( $from ) : null,
                        $to ? $this->getRevisionOrThrow( $to ) : null
                    );
                      Severity: Major
                      Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return $this->getCachedCount( $type,
                    function ( RevisionRecord $fromRev = null ) use ( $pageId ) {
                        return $this->getRevertedCount( $pageId, $fromRev );
                    }
                );
                        Severity: Major
                        Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                              return $this->getCachedCount( $type,
                        function ( RevisionRecord $fromRev = null ) use ( $pageId ) {
                            return $this->getEditsCount( $pageId, $fromRev );
                        }
                    );
                          Severity: Major
                          Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        case 'edits':
                $from = $this->getValidatedParams()['from'] ?? null;
                $to = $this->getValidatedParams()['to'] ?? null;
                if ( $from || $to ) {
                    return $this->getEditsCount(
                            Severity: Major
                            Found in includes/Rest/Handler/PageHistoryCountHandler.php and 1 other location - About 3 hrs to fix
                            includes/Rest/Handler/PageHistoryCountHandler.php on lines 216..230

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 146.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        case 'editors':
                $from = $this->getValidatedParams()['from'] ?? null;
                $to = $this->getValidatedParams()['to'] ?? null;
                if ( $from || $to ) {
                    return $this->getEditorsCount(
                            Severity: Major
                            Found in includes/Rest/Handler/PageHistoryCountHandler.php and 1 other location - About 3 hrs to fix
                            includes/Rest/Handler/PageHistoryCountHandler.php on lines 232..247

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 146.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                public function __construct(
        RevisionStore $revisionStore,
        NameTableStoreFactory $nameTableStoreFactory,
        GroupPermissionsLookup $groupPermissionsLookup,
        IConnectionProvider $dbProvider,
                            Severity: Major
                            Found in includes/Rest/Handler/PageHistoryCountHandler.php and 1 other location - About 1 hr to fix
                            includes/Rest/Handler/PageHistoryHandler.php on lines 60..76

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 119.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status