Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Rest/Handler/PageHistoryHandler.php

Summary

Maintainability
F
3 days
Test Coverage

Function processDbResults has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    private function processDbResults( $res, $page, $params ) {
        $revisions = [];

        if ( $res ) {
            $sizes = [];
Severity: Minor
Found in includes/Rest/Handler/PageHistoryHandler.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File PageHistoryHandler.php has 352 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace MediaWiki\Rest\Handler;

use ChangeTags;
Severity: Minor
Found in includes/Rest/Handler/PageHistoryHandler.php - About 4 hrs to fix

    Method processDbResults has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function processDbResults( $res, $page, $params ) {
        $revisions = [];

        if ( $res ) {
            $sizes = [];
    Severity: Major
    Found in includes/Rest/Handler/PageHistoryHandler.php - About 3 hrs to fix

      Method run has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function run( $title ) {
        $params = $this->getValidatedParams();
        if ( $params['older_than'] !== null && $params['newer_than'] !== null ) {
            throw new LocalizedHttpException(
                new MessageValue( 'rest-pagehistory-incompatible-params' ), 400 );
      Severity: Major
      Found in includes/Rest/Handler/PageHistoryHandler.php - About 2 hrs to fix

        Function run has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function run( $title ) {
        $params = $this->getValidatedParams();
        if ( $params['older_than'] !== null && $params['newer_than'] !== null ) {
            throw new LocalizedHttpException(
                new MessageValue( 'rest-pagehistory-incompatible-params' ), 400 );
        Severity: Minor
        Found in includes/Rest/Handler/PageHistoryHandler.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getDbResults has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getDbResults( ExistingPageRecord $page, array $params, $relativeRevId, $ts, $tagIds ) {
        $dbr = $this->dbProvider->getReplicaDatabase();
        $queryBuilder = $this->revisionStore->newSelectQueryBuilder( $dbr )
            ->joinComment()
            ->where( [ 'rev_page' => $page->getId() ] )
        Severity: Major
        Found in includes/Rest/Handler/PageHistoryHandler.php - About 2 hrs to fix

          Function getDbResults has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getDbResults( ExistingPageRecord $page, array $params, $relativeRevId, $ts, $tagIds ) {
        $dbr = $this->dbProvider->getReplicaDatabase();
        $queryBuilder = $this->revisionStore->newSelectQueryBuilder( $dbr )
            ->joinComment()
            ->where( [ 'rev_page' => $page->getId() ] )
          Severity: Minor
          Found in includes/Rest/Handler/PageHistoryHandler.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  RevisionStore $revisionStore,
        NameTableStoreFactory $nameTableStoreFactory,
        GroupPermissionsLookup $groupPermissionsLookup,
        IConnectionProvider $dbProvider,
        PageLookup $pageLookup,
          Severity: Major
          Found in includes/Rest/Handler/PageHistoryHandler.php - About 50 mins to fix

            Method getDbResults has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private function getDbResults( ExistingPageRecord $page, array $params, $relativeRevId, $ts, $tagIds ) {
            Severity: Minor
            Found in includes/Rest/Handler/PageHistoryHandler.php - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function __construct(
        RevisionStore $revisionStore,
        NameTableStoreFactory $nameTableStoreFactory,
        GroupPermissionsLookup $groupPermissionsLookup,
        IConnectionProvider $dbProvider,
              Severity: Major
              Found in includes/Rest/Handler/PageHistoryHandler.php and 1 other location - About 1 hr to fix
              includes/Rest/Handler/PageHistoryCountHandler.php on lines 75..91

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 119.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status