Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Rest/Router.php

Summary

Maintainability
D
1 day
Test Coverage

File Router.php has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace MediaWiki\Rest;

use HttpStatus;
Severity: Minor
Found in includes/Rest/Router.php - About 5 hrs to fix

    Router has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Router {
    private const PREFIX_PATTERN = '!^/([-_.\w]+(?:/v\d+)?)(/.*)$!';

    /** @var string[] */
    private $routeFiles;
    Severity: Minor
    Found in includes/Rest/Router.php - About 3 hrs to fix

      Function buildModuleMap has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          private function buildModuleMap(): array {
        $modules = [];
        $noPrefixFiles = [];
        $id = ''; // should not be used, make Phan happy
      Severity: Minor
      Found in includes/Rest/Router.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method buildModuleMap has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function buildModuleMap(): array {
        $modules = [];
        $noPrefixFiles = [];
        $id = ''; // should not be used, make Phan happy
      Severity: Minor
      Found in includes/Rest/Router.php - About 1 hr to fix

        Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                array $routeFiles,
        array $extraRoutes,
        ServiceOptions $options,
        BagOStuff $cacheBag,
        ResponseFactory $responseFactory,
        Severity: Major
        Found in includes/Rest/Router.php - About 1 hr to fix

          Method getModule has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getModule( string $name ): ?Module {
        if ( isset( $this->modules[$name] ) ) {
            return $this->modules[$name];
        }
          Severity: Minor
          Found in includes/Rest/Router.php - About 1 hr to fix

            Function getModule has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getModule( string $name ): ?Module {
        if ( isset( $this->modules[$name] ) ) {
            return $this->modules[$name];
        }
            Severity: Minor
            Found in includes/Rest/Router.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status