Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Revision/RenderedRevision.php

Summary

Maintainability
C
1 day
Test Coverage

Consider simplifying this complex logical expression.
Open

        if ( $parserOutput->getOutputFlag( ParserOutputFlags::VARY_REVISION ) ) {
            // If {{PAGEID}} resolved to 0, then that word need to resolve to the actual page ID
            $logger->info( "$varyMsg (vary-revision)", $context );
            return true;
        } elseif (
Severity: Critical
Found in includes/Revision/RenderedRevision.php - About 2 hrs to fix

    Method outputVariesOnRevisionMetaData has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function outputVariesOnRevisionMetaData(
        ParserOutput $parserOutput,
        $actualPageId,
        $actualRevId,
        $actualRevTimestamp
    Severity: Minor
    Found in includes/Revision/RenderedRevision.php - About 1 hr to fix

      Function outputVariesOnRevisionMetaData has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          private function outputVariesOnRevisionMetaData(
        ParserOutput $parserOutput,
        $actualPageId,
        $actualRevId,
        $actualRevTimestamp
      Severity: Minor
      Found in includes/Revision/RenderedRevision.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              RevisionRecord $revision,
        ParserOptions $options,
        ContentRenderer $contentRenderer,
        callable $combineOutput,
        $audience = RevisionRecord::FOR_PUBLIC,
      Severity: Minor
      Found in includes/Revision/RenderedRevision.php - About 45 mins to fix

        Function pruneRevisionSensitiveOutput has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function pruneRevisionSensitiveOutput(
        $actualPageId,
        $actualRevId,
        $actualRevTimestamp
    ) {
        Severity: Minor
        Found in includes/Revision/RenderedRevision.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return false;
        Severity: Major
        Found in includes/Revision/RenderedRevision.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return true;
          Severity: Major
          Found in includes/Revision/RenderedRevision.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return true;
            Severity: Major
            Found in includes/Revision/RenderedRevision.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status