Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Revision/RevisionRecord.php

Summary

Maintainability
B
6 hrs
Test Coverage

RevisionRecord has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class RevisionRecord implements WikiAwareEntity {
    use LegacyArticleIdAccess;
    use NonSerializableTrait;
    use WikiAwareEntityTrait;
Severity: Minor
Found in includes/Revision/RevisionRecord.php - About 3 hrs to fix

    Function userCanBitfield has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function userCanBitfield( $bitfield, $field, Authority $performer, PageIdentity $page = null ) {
        if ( $bitfield & $field ) { // aspect is deleted
            if ( $bitfield & self::DELETED_RESTRICTED ) {
                $permissions = [ 'suppressrevision', 'viewsuppressed' ];
            } elseif ( $field & self::DELETED_TEXT ) {
    Severity: Minor
    Found in includes/Revision/RevisionRecord.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function audienceCan has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function audienceCan( $field, $audience, Authority $performer = null ) {
        if ( $audience == self::FOR_PUBLIC && $this->isDeleted( $field ) ) {
            return false;
        } elseif ( $audience == self::FOR_THIS_USER ) {
            if ( !$performer ) {
    Severity: Minor
    Found in includes/Revision/RevisionRecord.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return false;
    Severity: Major
    Found in includes/Revision/RevisionRecord.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status