Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Settings/Source/JsonSchemaTrait.php

Summary

Maintainability
C
1 day
Test Coverage

Function doNormalizeJsonSchema has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    private static function doNormalizeJsonSchema(
        array $schema,
        array &$defs,
        string $source,
        string $propertyName,
Severity: Minor
Found in includes/Settings/Source/JsonSchemaTrait.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doNormalizeJsonSchema has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function doNormalizeJsonSchema(
        array $schema,
        array &$defs,
        string $source,
        string $propertyName,
Severity: Major
Found in includes/Settings/Source/JsonSchemaTrait.php - About 2 hrs to fix

    Method phpDocToJson has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function phpDocToJson( $phpDocType ) {
        static $jsonTypes = [
            'list' => 'array',
            'dict' => 'object',
            'map' => 'object',
    Severity: Minor
    Found in includes/Settings/Source/JsonSchemaTrait.php - About 1 hr to fix

      Method jsonToPhpDoc has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static function jsonToPhpDoc( $jsonSchemaType ) {
        static $phpTypes = [
            'array' => 'array',
            'object' => 'array', // could be optional
            'number' => 'float',
      Severity: Minor
      Found in includes/Settings/Source/JsonSchemaTrait.php - About 1 hr to fix

        Method doNormalizeJsonSchema has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                array $schema,
        array &$defs,
        string $source,
        string $propertyName,
        bool $inlineReferences,
        Severity: Minor
        Found in includes/Settings/Source/JsonSchemaTrait.php - About 45 mins to fix

          Function phpDocToJson has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private static function phpDocToJson( $phpDocType ) {
        static $jsonTypes = [
            'list' => 'array',
            'dict' => 'object',
            'map' => 'object',
          Severity: Minor
          Found in includes/Settings/Source/JsonSchemaTrait.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method normalizeJsonSchema has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  array $schema,
        array &$defs,
        string $source,
        string $propertyName,
        bool $inlineReferences = false
          Severity: Minor
          Found in includes/Settings/Source/JsonSchemaTrait.php - About 35 mins to fix

            Function jsonToPhpDoc has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function jsonToPhpDoc( $jsonSchemaType ) {
        static $phpTypes = [
            'array' => 'array',
            'object' => 'array', // could be optional
            'number' => 'float',
            Severity: Minor
            Found in includes/Settings/Source/JsonSchemaTrait.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status