wikimedia/mediawiki-core

View on GitHub
includes/Status/StatusFormatter.php

Summary

Maintainability
C
1 day
Test Coverage

Function getPsr3MessageAndContext has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function getPsr3MessageAndContext( StatusValue $status ): array {
        $options = [ 'lang' => 'en' ];
        $errors = $status->getErrors();

        if ( count( $errors ) === 1 ) {
Severity: Minor
Found in includes/Status/StatusFormatter.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getWikiText has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function getWikiText( StatusValue $status, array $options = [] ) {
        $shortContext = $options['shortContext'] ?? null;
        $longContext = $options['longContext'] ?? null;
        $lang = $options['lang'] ?? null;

Severity: Minor
Found in includes/Status/StatusFormatter.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getMessage has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getMessage( StatusValue $status, array $options = [] ) {
        $shortContext = $options['shortContext'] ?? null;
        $longContext = $options['longContext'] ?? null;
        $lang = $options['lang'] ?? null;

Severity: Minor
Found in includes/Status/StatusFormatter.php - About 1 hr to fix

    Method getWikiText has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getWikiText( StatusValue $status, array $options = [] ) {
            $shortContext = $options['shortContext'] ?? null;
            $longContext = $options['longContext'] ?? null;
            $lang = $options['lang'] ?? null;
    
    
    Severity: Minor
    Found in includes/Status/StatusFormatter.php - About 1 hr to fix

      Function getMessage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getMessage( StatusValue $status, array $options = [] ) {
              $shortContext = $options['shortContext'] ?? null;
              $longContext = $options['longContext'] ?? null;
              $lang = $options['lang'] ?? null;
      
      
      Severity: Minor
      Found in includes/Status/StatusFormatter.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getPsr3MessageAndContext has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getPsr3MessageAndContext( StatusValue $status ): array {
              $options = [ 'lang' => 'en' ];
              $errors = $status->getErrors();
      
              if ( count( $errors ) === 1 ) {
      Severity: Minor
      Found in includes/Status/StatusFormatter.php - About 1 hr to fix

        Method getErrorMessage has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getErrorMessage( $error, array $options = [] ) {
                $lang = $options['lang'] ?? null;
        
                if ( is_array( $error ) ) {
                    if ( isset( $error['message'] ) && $error['message'] instanceof Message ) {
        Severity: Minor
        Found in includes/Status/StatusFormatter.php - About 1 hr to fix

          Function getErrorMessage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getErrorMessage( $error, array $options = [] ) {
                  $lang = $options['lang'] ?? null;
          
                  if ( is_array( $error ) ) {
                      if ( isset( $error['message'] ) && $error['message'] instanceof Message ) {
          Severity: Minor
          Found in includes/Status/StatusFormatter.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return [ $this->getWikiText( $status, $options ), [] ];
          Severity: Major
          Found in includes/Status/StatusFormatter.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status