Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/Storage/DerivedPageDataUpdater.php

Summary

Maintainability
F
1 wk
Test Coverage

File DerivedPageDataUpdater.php has 959 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Major
Found in includes/Storage/DerivedPageDataUpdater.php - About 2 days to fix

    DerivedPageDataUpdater has 54 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DerivedPageDataUpdater implements LoggerAwareInterface, PreparedUpdate {

    /**
     * @var UserIdentity|null
     */
    Severity: Major
    Found in includes/Storage/DerivedPageDataUpdater.php - About 7 hrs to fix

      Method prepareUpdate has 120 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function prepareUpdate( RevisionRecord $revision, array $options = [] ) {
        Assert::parameter(
            !isset( $options['oldrevision'] )
            || $options['oldrevision'] instanceof RevisionRecord,
            '$options["oldrevision"]',
      Severity: Major
      Found in includes/Storage/DerivedPageDataUpdater.php - About 4 hrs to fix

        Function doUpdates has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
        Open

            public function doUpdates() {
        $this->assertTransition( 'done' );

        // TODO: move logic into a PageEventEmitter service
        Severity: Minor
        Found in includes/Storage/DerivedPageDataUpdater.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method prepareContent has 113 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function prepareContent(
        UserIdentity $user,
        RevisionSlotsUpdate $slotsUpdate,
        $useStash = true
    ) {
        Severity: Major
        Found in includes/Storage/DerivedPageDataUpdater.php - About 4 hrs to fix

          Method doUpdates has 108 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function doUpdates() {
        $this->assertTransition( 'done' );

        // TODO: move logic into a PageEventEmitter service
          Severity: Major
          Found in includes/Storage/DerivedPageDataUpdater.php - About 4 hrs to fix

            Function prepareContent has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

                public function prepareContent(
        UserIdentity $user,
        RevisionSlotsUpdate $slotsUpdate,
        $useStash = true
    ) {
            Severity: Minor
            Found in includes/Storage/DerivedPageDataUpdater.php - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function prepareUpdate has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

                public function prepareUpdate( RevisionRecord $revision, array $options = [] ) {
        Assert::parameter(
            !isset( $options['oldrevision'] )
            || $options['oldrevision'] instanceof RevisionRecord,
            '$options["oldrevision"]',
            Severity: Minor
            Found in includes/Storage/DerivedPageDataUpdater.php - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 19 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    ServiceOptions $options,
        WikiPage $wikiPage,
        RevisionStore $revisionStore,
        RevisionRenderer $revisionRenderer,
        SlotRoleRegistry $slotRoleRegistry,
            Severity: Major
            Found in includes/Storage/DerivedPageDataUpdater.php - About 2 hrs to fix

              Method getSecondaryDataUpdates has 48 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getSecondaryDataUpdates( $recursive = false ) {
        if ( $this->isContentDeleted() ) {
            // This shouldn't happen, since the current content is always public,
            // and DataUpdates are only needed for current content.
            return [];
              Severity: Minor
              Found in includes/Storage/DerivedPageDataUpdater.php - About 1 hr to fix

                Method isReusableFor has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function isReusableFor(
        UserIdentity $user = null,
        RevisionRecord $revision = null,
        RevisionSlotsUpdate $slotsUpdate = null,
        $parentId = null
                Severity: Minor
                Found in includes/Storage/DerivedPageDataUpdater.php - About 1 hr to fix

                  Function isCountable has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function isCountable(): bool {
        // NOTE: Keep in sync with WikiPage::isCountable.

        if ( !$this->getTitle()->isContentPage() ) {
            return false;
                  Severity: Minor
                  Found in includes/Storage/DerivedPageDataUpdater.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function isReusableFor has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function isReusableFor(
        UserIdentity $user = null,
        RevisionRecord $revision = null,
        RevisionSlotsUpdate $slotsUpdate = null,
        $parentId = null
                  Severity: Minor
                  Found in includes/Storage/DerivedPageDataUpdater.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                              return false;
                  Severity: Major
                  Found in includes/Storage/DerivedPageDataUpdater.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return true;
                    Severity: Major
                    Found in includes/Storage/DerivedPageDataUpdater.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return false;
                      Severity: Major
                      Found in includes/Storage/DerivedPageDataUpdater.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return false;
                        Severity: Major
                        Found in includes/Storage/DerivedPageDataUpdater.php - About 30 mins to fix

                          Function getSecondaryDataUpdates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function getSecondaryDataUpdates( $recursive = false ) {
        if ( $this->isContentDeleted() ) {
            // This shouldn't happen, since the current content is always public,
            // and DataUpdates are only needed for current content.
            return [];
                          Severity: Minor
                          Found in includes/Storage/DerivedPageDataUpdater.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              private $options = [
        'changed' => true,
        // newrev is true if prepareUpdate is handling the creation of a new revision,
        // as opposed to a null edit or a forced update.
        'newrev' => false,
                          Severity: Major
                          Found in includes/Storage/DerivedPageDataUpdater.php and 1 other location - About 1 hr to fix
                          includes/tidy/RemexCompatMunger.php on lines 93..108

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 119.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status