includes/Storage/PageEditStash.php
File PageEditStash.php
has 328 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
Function checkCache
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
Open
public function checkCache( PageIdentity $page, Content $content, UserIdentity $user ) {
$legacyUser = $this->userFactory->newFromUserIdentity( $user );
if (
// The context is not an HTTP POST request
!$legacyUser->getRequest()->wasPosted() ||
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method checkCache
has 77 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function checkCache( PageIdentity $page, Content $content, UserIdentity $user ) {
$legacyUser = $this->userFactory->newFromUserIdentity( $user );
if (
// The context is not an HTTP POST request
!$legacyUser->getRequest()->wasPosted() ||
Method parseAndCache
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function parseAndCache( $pageUpdater, Content $content, UserIdentity $user, string $summary ) {
$logger = $this->logger;
if ( $pageUpdater instanceof WikiPage ) {
wfDeprecated( __METHOD__ . ' with WikiPage instance', '1.42' );
Function parseAndCache
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
public function parseAndCache( $pageUpdater, Content $content, UserIdentity $user, string $summary ) {
$logger = $this->logger;
if ( $pageUpdater instanceof WikiPage ) {
wfDeprecated( __METHOD__ . ' with WikiPage instance', '1.42' );
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
BagOStuff $cache,
IConnectionProvider $dbProvider,
LoggerInterface $logger,
StatsdDataFactoryInterface $stats,
UserEditTracker $userEditTracker,
Method storeStashValue
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
$key,
Content $pstContent,
ParserOutput $parserOutput,
$timestamp,
UserIdentity $user
Avoid too many return
statements within this method. Open
Open
return self::ERROR_PARSE;
Avoid too many return
statements within this method. Open
Open
return self::ERROR_CACHE;