Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/actions/DeleteAction.php

Summary

Maintainability
D
2 days
Test Coverage

File DeleteAction.php has 481 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/actions/DeleteAction.php - About 7 hrs to fix

    DeleteAction has 28 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DeleteAction extends FormAction {

    /**
     * Constants used to localize form fields
     */
    Severity: Minor
    Found in includes/actions/DeleteAction.php - About 3 hrs to fix

      Method tempDelete has 81 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function tempDelete() {
        $article = $this->getArticle();
        $title = $this->getTitle();
        $context = $this->getContext();
        $user = $context->getUser();
      Severity: Major
      Found in includes/actions/DeleteAction.php - About 3 hrs to fix

        Method getFormFields has 74 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function getFormFields(): array {
        $user = $this->getUser();
        $title = $this->getTitle();
        $article = $this->getArticle();
        Severity: Major
        Found in includes/actions/DeleteAction.php - About 2 hrs to fix

          Function tempDelete has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function tempDelete() {
        $article = $this->getArticle();
        $title = $this->getTitle();
        $context = $this->getContext();
        $user = $context->getUser();
          Severity: Minor
          Found in includes/actions/DeleteAction.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method showSuccessMessages has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function showSuccessMessages( array $deleted, array $scheduled ): void {
        $outputPage = $this->getContext()->getOutput();
        $loglink = '[[Special:Log/delete|' . $this->msg( 'deletionlog' )->text() . ']]';
        $pageBaseDisplayTitle = wfEscapeWikiText( $this->getTitle()->getPrefixedText() );
        $pageTalkDisplayTitle = wfEscapeWikiText( $this->titleFormatter->getPrefixedText(
          Severity: Minor
          Found in includes/actions/DeleteAction.php - About 1 hr to fix

            Method showHistoryWarnings has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function showHistoryWarnings(): void {
        $context = $this->getContext();
        $title = $this->getTitle();

        // The following can use the real revision count as this is only being shown for users
            Severity: Minor
            Found in includes/actions/DeleteAction.php - About 1 hr to fix

              Function showSuccessMessages has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function showSuccessMessages( array $deleted, array $scheduled ): void {
        $outputPage = $this->getContext()->getOutput();
        $loglink = '[[Special:Log/delete|' . $this->msg( 'deletionlog' )->text() . ']]';
        $pageBaseDisplayTitle = wfEscapeWikiText( $this->getTitle()->getPrefixedText() );
        $pageTalkDisplayTitle = wfEscapeWikiText( $this->titleFormatter->getPrefixedText(
              Severity: Minor
              Found in includes/actions/DeleteAction.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status