Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/actions/InfoAction.php

Summary

Maintainability
F
1 wk
Test Coverage

Method pageInfo has 417 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function pageInfo() {
        $user = $this->getUser();
        $lang = $this->getLanguage();
        $title = $this->getTitle();
        $id = $title->getArticleID();
Severity: Major
Found in includes/actions/InfoAction.php - About 2 days to fix

    File InfoAction.php has 737 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Displays information about a page.
 *
 * Copyright © 2011 Alexandre Emsenhuber
    Severity: Major
    Found in includes/actions/InfoAction.php - About 1 day to fix

      Function pageInfo has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
      Open

          private function pageInfo() {
        $user = $this->getUser();
        $lang = $this->getLanguage();
        $title = $this->getTitle();
        $id = $title->getArticleID();
      Severity: Minor
      Found in includes/actions/InfoAction.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method pageCounts has 100 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function pageCounts() {
        $page = $this->getWikiPage();
        $fname = __METHOD__;
        $config = $this->context->getConfig();
        $cache = $this->wanObjectCache;
      Severity: Major
      Found in includes/actions/InfoAction.php - About 4 hrs to fix

        Method __construct has 18 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Article $article,
        IContextSource $context,
        Language $contentLanguage,
        LanguageNameUtils $languageNameUtils,
        LinkBatchFactory $linkBatchFactory,
        Severity: Major
        Found in includes/actions/InfoAction.php - About 2 hrs to fix

          Method onView has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function onView() {
        $this->getOutput()->addModuleStyles( [
            'mediawiki.interface.helpers.styles',
            'mediawiki.action.styles',
        ] );
          Severity: Minor
          Found in includes/actions/InfoAction.php - About 1 hr to fix

            Function onView has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                public function onView() {
        $this->getOutput()->addModuleStyles( [
            'mediawiki.interface.helpers.styles',
            'mediawiki.action.styles',
        ] );
            Severity: Minor
            Found in includes/actions/InfoAction.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getNamespaceProtectionMessage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getNamespaceProtectionMessage( Title $title ): ?string {
        $rights = [];
        if ( $title->isRawHtmlMessage() ) {
            $rights[] = 'editsitecss';
            $rights[] = 'editsitejs';
            Severity: Minor
            Found in includes/actions/InfoAction.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getNamespaceProtectionMessage has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function getNamespaceProtectionMessage( Title $title ): ?string {
        $rights = [];
        if ( $title->isRawHtmlMessage() ) {
            $rights[] = 'editsitecss';
            $rights[] = 'editsitejs';
            Severity: Minor
            Found in includes/actions/InfoAction.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function __construct(
        Article $article,
        IContextSource $context,
        Language $contentLanguage,
        LanguageNameUtils $languageNameUtils,
              Severity: Major
              Found in includes/actions/InfoAction.php and 1 other location - About 2 hrs to fix
              includes/page/MovePage.php on lines 182..223

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 127.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status