Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/actions/RawAction.php

Summary

Maintainability
D
1 day
Test Coverage

Method onView has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function onView() {
        $this->getOutput()->disable();
        $request = $this->getRequest();
        $response = $request->response();
        $config = $this->context->getConfig();
Severity: Major
Found in includes/actions/RawAction.php - About 3 hrs to fix

    Function getRawText has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getRawText() {
        $text = false;
        $title = $this->getTitle();
        $request = $this->getRequest();
    Severity: Minor
    Found in includes/actions/RawAction.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onView has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public function onView() {
        $this->getOutput()->disable();
        $request = $this->getRequest();
        $response = $request->response();
        $config = $this->context->getConfig();
    Severity: Minor
    Found in includes/actions/RawAction.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getRawText has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getRawText() {
        $text = false;
        $title = $this->getTitle();
        $request = $this->getRequest();
    Severity: Minor
    Found in includes/actions/RawAction.php - About 1 hr to fix

      Method getOldId has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getOldId() {
        $oldId = $this->getRequest()->getInt( 'oldid' );
        $rl = $this->revisionLookup;
        switch ( $this->getRequest()->getText( 'direction' ) ) {
            case 'next':
      Severity: Minor
      Found in includes/actions/RawAction.php - About 1 hr to fix

        Function getOldId has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getOldId() {
        $oldId = $this->getRequest()->getInt( 'oldid' );
        $rl = $this->revisionLookup;
        switch ( $this->getRequest()->getText( 'direction' ) ) {
            case 'next':
        Severity: Minor
        Found in includes/actions/RawAction.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Article $article,
        IContextSource $context,
        Parser $parser,
        PermissionManager $permissionManager,
        RevisionLookup $revisionLookup,
        Severity: Major
        Found in includes/actions/RawAction.php - About 50 mins to fix

          Function getContentType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getContentType() {
        // Optimisation: Avoid slow getVal(), this isn't user-generated content.
        $ctype = $this->getRequest()->getRawVal( 'ctype' );

        if ( $ctype == '' ) {
          Severity: Minor
          Found in includes/actions/RawAction.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function __construct(
        Article $article,
        IContextSource $context,
        Parser $parser,
        PermissionManager $permissionManager,
          Severity: Major
          Found in includes/actions/RawAction.php and 1 other location - About 1 hr to fix
          includes/actions/RollbackAction.php on lines 61..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status