Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/api/ApiCSPReport.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method getFlags has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getFlags( $report, $userAgent ) {
        $reportOnly = $this->getParameter( 'reportonly' );
        $source = $this->getParameter( 'source' );
        $falsePositives = $this->getConfig()->get( MainConfigNames::CSPFalsePositiveUrls );
Severity: Minor
Found in includes/api/ApiCSPReport.php - About 1 hr to fix

    Function getFlags has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getFlags( $report, $userAgent ) {
        $reportOnly = $this->getParameter( 'reportonly' );
        $source = $this->getParameter( 'source' );
        $falsePositives = $this->getConfig()->get( MainConfigNames::CSPFalsePositiveUrls );
    Severity: Minor
    Found in includes/api/ApiCSPReport.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

            if (
            (
                ContentSecurityPolicy::falsePositiveBrowser( $userAgent ) &&
                $report['blocked-uri'] === "self"
            ) ||
    Severity: Major
    Found in includes/api/ApiCSPReport.php - About 40 mins to fix

      Function matchUrlPattern has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function matchUrlPattern( $url, array $patterns ) {
        if ( isset( $patterns[ $url ] ) ) {
            return true;
        }
      Severity: Minor
      Found in includes/api/ApiCSPReport.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status