Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/api/ApiFeedWatchlist.php

Summary

Maintainability
D
1 day
Test Coverage

Method execute has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        $config = $this->getConfig();
        $feedClasses = $config->get( MainConfigNames::FeedClasses );
        $params = [];
        $feedItems = [];
Severity: Major
Found in includes/api/ApiFeedWatchlist.php - About 3 hrs to fix

    Function execute has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        public function execute() {
        $config = $this->getConfig();
        $feedClasses = $config->get( MainConfigNames::FeedClasses );
        $params = [];
        $feedItems = [];
    Severity: Minor
    Found in includes/api/ApiFeedWatchlist.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createFeedItem has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        private function createFeedItem( $info ) {
        if ( !isset( $info['title'] ) ) {
            // Probably a revdeled log entry, skip it.
            return null;
        }
    Severity: Minor
    Found in includes/api/ApiFeedWatchlist.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getAllowedParams has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getAllowedParams( $flags = 0 ) {
        $feedFormatNames = array_keys( $this->getConfig()->get( MainConfigNames::FeedClasses ) );
        $ret = [
            'feedformat' => [
                ParamValidator::PARAM_DEFAULT => 'rss',
    Severity: Minor
    Found in includes/api/ApiFeedWatchlist.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getAllowedParams has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getAllowedParams( $flags = 0 ) {
        $feedFormatNames = array_keys( $this->getConfig()->get( MainConfigNames::FeedClasses ) );
        $ret = [
            'feedformat' => [
                ParamValidator::PARAM_DEFAULT => 'rss',
    Severity: Minor
    Found in includes/api/ApiFeedWatchlist.php - About 1 hr to fix

      Method createFeedItem has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function createFeedItem( $info ) {
        if ( !isset( $info['title'] ) ) {
            // Probably a revdeled log entry, skip it.
            return null;
        }
      Severity: Minor
      Found in includes/api/ApiFeedWatchlist.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status