Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/api/ApiOpenSearch.php

Summary

Maintainability
D
1 day
Test Coverage

Function search has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    private function search( $search, array $params ) {
        $searchEngine = $this->buildSearchEngine( $params );
        $titles = $searchEngine->extractTitles( $searchEngine->completionSearchWithVariants( $search ) );
        $results = [];
Severity: Minor
Found in includes/api/ApiOpenSearch.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method search has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function search( $search, array $params ) {
        $searchEngine = $this->buildSearchEngine( $params );
        $titles = $searchEngine->extractTitles( $searchEngine->completionSearchWithVariants( $search ) );
        $results = [];
Severity: Major
Found in includes/api/ApiOpenSearch.php - About 3 hrs to fix

    File ApiOpenSearch.php has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Copyright © 2006 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
 * Copyright © 2008 Brooke Vibber <bvibber@wikimedia.org>
 * Copyright © 2014 Wikimedia Foundation and contributors
    Severity: Minor
    Found in includes/api/ApiOpenSearch.php - About 2 hrs to fix

      Method populateResult has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function populateResult( $search, &$results ) {
        $result = $this->getResult();

        switch ( $this->getFormat() ) {
            case 'json':
      Severity: Minor
      Found in includes/api/ApiOpenSearch.php - About 2 hrs to fix

        Function populateResult has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function populateResult( $search, &$results ) {
        $result = $this->getResult();

        switch ( $this->getFormat() ) {
            case 'json':
        Severity: Minor
        Found in includes/api/ApiOpenSearch.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                ApiMain $mainModule,
        $moduleName,
        LinkBatchFactory $linkBatchFactory,
        SearchEngineConfig $searchEngineConfig,
        SearchEngineFactory $searchEngineFactory,
        Severity: Minor
        Found in includes/api/ApiOpenSearch.php - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status