Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/api/ApiQueryCategoryMembers.php

Summary

Maintainability
F
4 days
Test Coverage

Function run has a Cognitive Complexity of 90 (exceeds 5 allowed). Consider refactoring.
Open

    private function run( $resultPageSet = null ) {
        $params = $this->extractRequestParams();

        $categoryTitle = $this->getTitleOrPageId( $params )->getTitle();
        if ( $categoryTitle->getNamespace() !== NS_CATEGORY ) {
Severity: Minor
Found in includes/api/ApiQueryCategoryMembers.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 187 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function run( $resultPageSet = null ) {
        $params = $this->extractRequestParams();

        $categoryTitle = $this->getTitleOrPageId( $params )->getTitle();
        if ( $categoryTitle->getNamespace() !== NS_CATEGORY ) {
Severity: Major
Found in includes/api/ApiQueryCategoryMembers.php - About 7 hrs to fix

    File ApiQueryCategoryMembers.php has 315 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Copyright © 2006 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
 *
 * This program is free software; you can redistribute it and/or modify
    Severity: Minor
    Found in includes/api/ApiQueryCategoryMembers.php - About 3 hrs to fix

      Method getAllowedParams has 84 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getAllowedParams() {
        $ret = [
            'title' => [
                ParamValidator::PARAM_TYPE => 'string',
            ],
      Severity: Major
      Found in includes/api/ApiQueryCategoryMembers.php - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if ( $params['startsortkeyprefix'] !== null ) {
                    $startsortkey = $this->collation->getSortKey( $params['startsortkeyprefix'] );
                } elseif ( $params['starthexsortkey'] !== null ) {
                    if ( !$this->validateHexSortkey( $params['starthexsortkey'] ) ) {
                        $encParamName = $this->encodeParamName( 'starthexsortkey' );
        Severity: Major
        Found in includes/api/ApiQueryCategoryMembers.php and 1 other location - About 2 hrs to fix
        includes/api/ApiQueryCategoryMembers.php on lines 171..181

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 134.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if ( $params['endsortkeyprefix'] !== null ) {
                    $endsortkey = $this->collation->getSortKey( $params['endsortkeyprefix'] );
                } elseif ( $params['endhexsortkey'] !== null ) {
                    if ( !$this->validateHexSortkey( $params['endhexsortkey'] ) ) {
                        $encParamName = $this->encodeParamName( 'endhexsortkey' );
        Severity: Major
        Found in includes/api/ApiQueryCategoryMembers.php and 1 other location - About 2 hrs to fix
        includes/api/ApiQueryCategoryMembers.php on lines 160..170

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 134.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status