Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/api/ApiQueryImageInfo.php

Summary

Maintainability
F
1 wk
Test Coverage

Function execute has a Cognitive Complexity of 106 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        $params = $this->extractRequestParams();

        $prop = array_fill_keys( $params['prop'], true );
Severity: Minor
Found in includes/api/ApiQueryImageInfo.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getInfo has a Cognitive Complexity of 93 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getInfo( $file, $prop, $result, $thumbParams = null, $opts = false ) {
        $anyHidden = false;

        $services = MediaWikiServices::getInstance();
Severity: Minor
Found in includes/api/ApiQueryImageInfo.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ApiQueryImageInfo.php has 604 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Copyright © 2006 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
 *
 * This program is free software; you can redistribute it and/or modify
Severity: Major
Found in includes/api/ApiQueryImageInfo.php - About 1 day to fix

    Method getInfo has 196 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function getInfo( $file, $prop, $result, $thumbParams = null, $opts = false ) {
        $anyHidden = false;

        $services = MediaWikiServices::getInstance();
    Severity: Major
    Found in includes/api/ApiQueryImageInfo.php - About 7 hrs to fix

      Method execute has 153 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function execute() {
        $params = $this->extractRequestParams();

        $prop = array_fill_keys( $params['prop'], true );
      Severity: Major
      Found in includes/api/ApiQueryImageInfo.php - About 6 hrs to fix

        Method getAllowedParams has 64 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getAllowedParams() {
        return [
            'prop' => [
                ParamValidator::PARAM_ISMULTI => true,
                ParamValidator::PARAM_DEFAULT => 'timestamp|user',
        Severity: Major
        Found in includes/api/ApiQueryImageInfo.php - About 2 hrs to fix

          Method mergeThumbParams has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function mergeThumbParams( $image, $thumbParams, $otherParams ) {
        if ( $thumbParams === null ) {
            // No scaling requested
            return null;
        }
          Severity: Minor
          Found in includes/api/ApiQueryImageInfo.php - About 1 hr to fix

            Function mergeThumbParams has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function mergeThumbParams( $image, $thumbParams, $otherParams ) {
        if ( $thumbParams === null ) {
            // No scaling requested
            return null;
        }
            Severity: Minor
            Found in includes/api/ApiQueryImageInfo.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    ApiQuery $query,
        $moduleName,
        $prefixOrRepoGroup = null,
        $repoGroupOrContentLanguage = null,
        $contentLanguageOrBadFileLookup = null,
            Severity: Minor
            Found in includes/api/ApiQueryImageInfo.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if ( isset( $prop['thumbmime'] ) && $file->getHandler() ) {
                            [ , $mime ] = $file->getHandler()->getThumbType(
                                $mto->getExtension(), $file->getMimeType(), $thumbParams );
                            $vals['thumbmime'] = $mime;
                        }
              Severity: Major
              Found in includes/api/ApiQueryImageInfo.php - About 45 mins to fix

                Method getInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public static function getInfo( $file, $prop, $result, $thumbParams = null, $opts = false ) {
                Severity: Minor
                Found in includes/api/ApiQueryImageInfo.php - About 35 mins to fix

                  Function processMetaData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function processMetaData( $metadata, $result ) {
        $retval = [];
        if ( is_array( $metadata ) ) {
            foreach ( $metadata as $key => $value ) {
                $r = [
                  Severity: Minor
                  Found in includes/api/ApiQueryImageInfo.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                          return $finalParams;
                  Severity: Major
                  Found in includes/api/ApiQueryImageInfo.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return $vals;
                    Severity: Major
                    Found in includes/api/ApiQueryImageInfo.php - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  [
                'timestamp' => 'apihelp-query+imageinfo-paramvalue-prop-timestamp',
                'user' => 'apihelp-query+imageinfo-paramvalue-prop-user',
                'userid' => 'apihelp-query+imageinfo-paramvalue-prop-userid',
                'comment' => 'apihelp-query+imageinfo-paramvalue-prop-comment',
                      Severity: Major
                      Found in includes/api/ApiQueryImageInfo.php and 1 other location - About 1 hr to fix
                      languages/messages/MessagesEn.php on lines 165..189

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 102.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status