Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/api/ApiQueryRandom.php

Summary

Maintainability
C
1 day
Test Coverage

Function runQuery has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    protected function runQuery( $resultPageSet, $limit, $start, $startId, $end ) {
        $params = $this->extractRequestParams();

        $this->resetQueryParams();
        $this->addTables( 'page' );
Severity: Minor
Found in includes/api/ApiQueryRandom.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method runQuery has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function runQuery( $resultPageSet, $limit, $start, $startId, $end ) {
        $params = $this->extractRequestParams();

        $this->resetQueryParams();
        $this->addTables( 'page' );
Severity: Major
Found in includes/api/ApiQueryRandom.php - About 2 hrs to fix

    Method run has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run( $resultPageSet = null ) {
        $params = $this->extractRequestParams();

        // Since 'filterredir" will always be set in $params, we have to dig
        // into the WebRequest to see if it was actually passed.
    Severity: Minor
    Found in includes/api/ApiQueryRandom.php - About 1 hr to fix

      Function run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run( $resultPageSet = null ) {
        $params = $this->extractRequestParams();

        // Since 'filterredir" will always be set in $params, we have to dig
        // into the WebRequest to see if it was actually passed.
      Severity: Minor
      Found in includes/api/ApiQueryRandom.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method runQuery has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function runQuery( $resultPageSet, $limit, $start, $startId, $end ) {
      Severity: Minor
      Found in includes/api/ApiQueryRandom.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status