Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/api/ApiQueryRecentChanges.php

Summary

Maintainability
F
1 wk
Test Coverage

Function run has a Cognitive Complexity of 102 (exceeds 5 allowed). Consider refactoring.
Open

    public function run( $resultPageSet = null ) {
        $user = $this->getUser();
        /* Get the parameters of the request. */
        $params = $this->extractRequestParams();
Severity: Minor
Found in includes/api/ApiQueryRecentChanges.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 288 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run( $resultPageSet = null ) {
        $user = $this->getUser();
        /* Get the parameters of the request. */
        $params = $this->extractRequestParams();
Severity: Major
Found in includes/api/ApiQueryRecentChanges.php - About 1 day to fix

    Function extractRowInfo has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
    Open

        public function extractRowInfo( $row ) {
        /* Determine the title of the page that has been changed. */
        $title = Title::makeTitle( $row->rc_namespace, $row->rc_title );
        $user = $this->getUser();
    Severity: Minor
    Found in includes/api/ApiQueryRecentChanges.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File ApiQueryRecentChanges.php has 622 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Copyright © 2006 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
 *
 * This program is free software; you can redistribute it and/or modify
    Severity: Major
    Found in includes/api/ApiQueryRecentChanges.php - About 1 day to fix

      Consider simplifying this complex logical expression.
      Open

                  if ( ( isset( $show['minor'] ) && isset( $show['!minor'] ) )
                || ( isset( $show['bot'] ) && isset( $show['!bot'] ) )
                || ( isset( $show['anon'] ) && isset( $show['!anon'] ) )
                || ( isset( $show['redirect'] ) && isset( $show['!redirect'] ) )
                || ( isset( $show['patrolled'] ) && isset( $show['!patrolled'] ) )
      Severity: Critical
      Found in includes/api/ApiQueryRecentChanges.php - About 5 hrs to fix

        Method extractRowInfo has 123 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function extractRowInfo( $row ) {
        /* Determine the title of the page that has been changed. */
        $title = Title::makeTitle( $row->rc_namespace, $row->rc_title );
        $user = $this->getUser();
        Severity: Major
        Found in includes/api/ApiQueryRecentChanges.php - About 4 hrs to fix

          Method getAllowedParams has 96 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getAllowedParams() {
        $slotRoles = $this->slotRoleRegistry->getKnownRoles();
        sort( $slotRoles, SORT_STRING );

        return [
          Severity: Major
          Found in includes/api/ApiQueryRecentChanges.php - About 3 hrs to fix

            Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    ApiQuery $query,
        $moduleName,
        CommentStore $commentStore,
        RowCommentFormatter $commentFormatter,
        NameTableStore $changeTagDefStore,
            Severity: Major
            Found in includes/api/ApiQueryRecentChanges.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if ( ( isset( $show['minor'] ) && isset( $show['!minor'] ) )
                || ( isset( $show['bot'] ) && isset( $show['!bot'] ) )
                || ( isset( $show['anon'] ) && isset( $show['!anon'] ) )
                || ( isset( $show['redirect'] ) && isset( $show['!redirect'] ) )
                || ( isset( $show['patrolled'] ) && isset( $show['!patrolled'] ) )
              Severity: Major
              Found in includes/api/ApiQueryRecentChanges.php and 1 other location - About 1 hr to fix
              includes/api/ApiQueryUserContribs.php on lines 465..470

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                      if ( $params['tag'] !== null ) {
            $this->addTables( 'change_tag' );
            $this->addJoinConds( [ 'change_tag' => [ 'JOIN', [ 'rc_id=ct_rc_id' ] ] ] );
            try {
                $this->addWhereFld( 'ct_tag_id', $this->changeTagDefStore->getId( $params['tag'] ) );
              Severity: Major
              Found in includes/api/ApiQueryRecentChanges.php and 5 other locations - About 40 mins to fix
              includes/api/ApiQueryAllDeletedRevisions.php on lines 192..203
              includes/api/ApiQueryDeletedRevisions.php on lines 139..150
              includes/api/ApiQueryDeletedrevs.php on lines 155..166
              includes/api/ApiQueryLogEvents.php on lines 162..172
              includes/api/ApiQueryRevisions.php on lines 186..197

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 94.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status