Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/api/ApiQuerySiteinfo.php

Summary

Maintainability
F
1 wk
Test Coverage

File ApiQuerySiteinfo.php has 950 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Copyright © 2006 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
 *
 * This program is free software; you can redistribute it and/or modify
Severity: Major
Found in includes/api/ApiQuerySiteinfo.php - About 2 days to fix

    Function appendExtensions has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function appendExtensions( $property ) {
        $data = [];
        $credits = SpecialVersion::getCredits(
            ExtensionRegistry::getInstance(),
            $this->getConfig()
    Severity: Minor
    Found in includes/api/ApiQuerySiteinfo.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function execute has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

        public function execute() {
        $params = $this->extractRequestParams();
        $done = [];
        foreach ( $params['prop'] as $p ) {
            switch ( $p ) {
    Severity: Minor
    Found in includes/api/ApiQuerySiteinfo.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    ApiQuerySiteinfo has 37 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ApiQuerySiteinfo extends ApiQueryBase {

    private UserOptionsLookup $userOptionsLookup;
    private UserGroupManager $userGroupManager;
    private LanguageConverterFactory $languageConverterFactory;
    Severity: Minor
    Found in includes/api/ApiQuerySiteinfo.php - About 4 hrs to fix

      Method appendGeneralInfo has 119 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function appendGeneralInfo( $property ) {
        $config = $this->getConfig();
        $mainPage = Title::newMainPage();
        $logo = SkinModule::getAvailableLogos( $config );
      Severity: Major
      Found in includes/api/ApiQuerySiteinfo.php - About 4 hrs to fix

        Method execute has 98 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function execute() {
        $params = $this->extractRequestParams();
        $done = [];
        foreach ( $params['prop'] as $p ) {
            switch ( $p ) {
        Severity: Major
        Found in includes/api/ApiQuerySiteinfo.php - About 3 hrs to fix

          Function appendInterwikiMap has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function appendInterwikiMap( $property, $filter ) {
        $local = $filter ? $filter === 'local' : null;

        $params = $this->extractRequestParams();
        $langCode = $params['inlanguagecode'] ?? '';
          Severity: Minor
          Found in includes/api/ApiQuerySiteinfo.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function appendUserGroups has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function appendUserGroups( $property, $numberInGroup ) {
        $config = $this->getConfig();

        $data = [];
        $result = $this->getResult();
          Severity: Minor
          Found in includes/api/ApiQuerySiteinfo.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method appendExtensions has 68 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function appendExtensions( $property ) {
        $data = [];
        $credits = SpecialVersion::getCredits(
            ExtensionRegistry::getInstance(),
            $this->getConfig()
          Severity: Major
          Found in includes/api/ApiQuerySiteinfo.php - About 2 hrs to fix

            Function recAutopromote has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
            Open

                private function recAutopromote( $cond, $allowedConditions ) {
        $config = [];
        // First, checks if $cond is an array
        if ( is_array( $cond ) ) {
            // Checks if $cond[0] is a valid operand
            Severity: Minor
            Found in includes/api/ApiQuerySiteinfo.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method appendInterwikiMap has 59 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function appendInterwikiMap( $property, $filter ) {
        $local = $filter ? $filter === 'local' : null;

        $params = $this->extractRequestParams();
        $langCode = $params['inlanguagecode'] ?? '';
            Severity: Major
            Found in includes/api/ApiQuerySiteinfo.php - About 2 hrs to fix

              Method __construct has 17 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      ApiQuery $query,
        $moduleName,
        UserOptionsLookup $userOptionsLookup,
        UserGroupManager $userGroupManager,
        LanguageConverterFactory $languageConverterFactory,
              Severity: Major
              Found in includes/api/ApiQuerySiteinfo.php - About 2 hrs to fix

                Method getAllowedParams has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getAllowedParams() {
        return [
            'prop' => [
                ParamValidator::PARAM_DEFAULT => 'general',
                ParamValidator::PARAM_ISMULTI => true,
                Severity: Minor
                Found in includes/api/ApiQuerySiteinfo.php - About 1 hr to fix

                  Method appendUserGroups has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function appendUserGroups( $property, $numberInGroup ) {
        $config = $this->getConfig();

        $data = [];
        $result = $this->getResult();
                  Severity: Minor
                  Found in includes/api/ApiQuerySiteinfo.php - About 1 hr to fix

                    Function appendGeneralInfo has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function appendGeneralInfo( $property ) {
        $config = $this->getConfig();
        $mainPage = Title::newMainPage();
        $logo = SkinModule::getAvailableLogos( $config );
                    Severity: Minor
                    Found in includes/api/ApiQuerySiteinfo.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method recAutopromote has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function recAutopromote( $cond, $allowedConditions ) {
        $config = [];
        // First, checks if $cond is an array
        if ( is_array( $cond ) ) {
            // Checks if $cond[0] is a valid operand
                    Severity: Minor
                    Found in includes/api/ApiQuerySiteinfo.php - About 1 hr to fix

                      Function appendSkins has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function appendSkins( $property ) {
        $data = [];
        $allowed = $this->skinFactory->getAllowedSkins();
        $default = Skin::normalizeKey( 'default' );
                      Severity: Minor
                      Found in includes/api/ApiQuerySiteinfo.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method appendNamespaces has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function appendNamespaces( $property ) {
        $nsProtection = $this->getConfig()->get( MainConfigNames::NamespaceProtection );

        $data = [ ApiResult::META_TYPE => 'assoc' ];
        foreach ( $this->contentLanguage->getFormattedNamespaces() as $ns => $title ) {
                      Severity: Minor
                      Found in includes/api/ApiQuerySiteinfo.php - About 1 hr to fix

                        Method appendLanguageVariants has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function appendLanguageVariants( $property ) {
        $langNames = $this->languageConverterFactory->isConversionDisabled() ? [] :
            LanguageConverter::$languagesWithVariants;
        sort( $langNames );
                        Severity: Minor
                        Found in includes/api/ApiQuerySiteinfo.php - About 1 hr to fix

                          Method appendSkins has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function appendSkins( $property ) {
        $data = [];
        $allowed = $this->skinFactory->getAllowedSkins();
        $default = Skin::normalizeKey( 'default' );
                          Severity: Minor
                          Found in includes/api/ApiQuerySiteinfo.php - About 1 hr to fix

                            Function appendNamespaces has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                            Open

                                protected function appendNamespaces( $property ) {
        $nsProtection = $this->getConfig()->get( MainConfigNames::NamespaceProtection );

        $data = [ ApiResult::META_TYPE => 'assoc' ];
        foreach ( $this->contentLanguage->getFormattedNamespaces() as $ns => $title ) {
                            Severity: Minor
                            Found in includes/api/ApiQuerySiteinfo.php - About 55 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function appendDbReplLagInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                protected function appendDbReplLagInfo( $property, $includeAll ) {
        $data = [];
        $showHostnames = $this->getConfig()->get( MainConfigNames::ShowHostnames );
        if ( $includeAll ) {
            if ( !$showHostnames ) {
                            Severity: Minor
                            Found in includes/api/ApiQuerySiteinfo.php - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function appendLanguageVariants has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function appendLanguageVariants( $property ) {
        $langNames = $this->languageConverterFactory->isConversionDisabled() ? [] :
            LanguageConverter::$languagesWithVariants;
        sort( $langNames );
                            Severity: Minor
                            Found in includes/api/ApiQuerySiteinfo.php - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                public function __construct(
        ApiQuery $query,
        $moduleName,
        UserOptionsLookup $userOptionsLookup,
        UserGroupManager $userGroupManager,
                            Severity: Major
                            Found in includes/api/ApiQuerySiteinfo.php and 2 other locations - About 1 hr to fix
                            includes/api/ApiParse.php on lines 104..139
                            includes/api/ApiQueryInfo.php on lines 137..171

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 117.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status