Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/api/ApiQueryUserContribs.php

Summary

Maintainability
F
1 wk
Test Coverage

File ApiQueryUserContribs.php has 615 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Copyright © 2006 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
 *
 * This program is free software; you can redistribute it and/or modify
Severity: Major
Found in includes/api/ApiQueryUserContribs.php - About 1 day to fix

    Function execute has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
    Open

        public function execute() {
        // Parse some parameters
        $this->params = $this->extractRequestParams();

        $prop = array_fill_keys( $this->params['prop'], true );
    Severity: Minor
    Found in includes/api/ApiQueryUserContribs.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method execute has 227 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute() {
        // Parse some parameters
        $this->params = $this->extractRequestParams();

        $prop = array_fill_keys( $this->params['prop'], true );
    Severity: Major
    Found in includes/api/ApiQueryUserContribs.php - About 1 day to fix

      Function prepareQuery has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
      Open

          private function prepareQuery( array $users, $limit ) {
        $this->resetQueryParams();
        $db = $this->getDB();

        $queryBuilder = $this->revisionStore->newSelectQueryBuilder( $db )->joinComment()->joinPage();
      Severity: Minor
      Found in includes/api/ApiQueryUserContribs.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method prepareQuery has 128 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function prepareQuery( array $users, $limit ) {
        $this->resetQueryParams();
        $db = $this->getDB();

        $queryBuilder = $this->revisionStore->newSelectQueryBuilder( $db )->joinComment()->joinPage();
      Severity: Major
      Found in includes/api/ApiQueryUserContribs.php - About 5 hrs to fix

        Function extractRowInfo has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
        Open

            private function extractRowInfo( $row ) {
        $vals = [];
        $anyHidden = false;

        if ( $row->rev_deleted & RevisionRecord::DELETED_TEXT ) {
        Severity: Minor
        Found in includes/api/ApiQueryUserContribs.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getAllowedParams has 86 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getAllowedParams() {
        return [
            'limit' => [
                ParamValidator::PARAM_DEFAULT => 10,
                ParamValidator::PARAM_TYPE => 'limit',
        Severity: Major
        Found in includes/api/ApiQueryUserContribs.php - About 3 hrs to fix

          Method extractRowInfo has 77 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function extractRowInfo( $row ) {
        $vals = [];
        $anyHidden = false;

        if ( $row->rev_deleted & RevisionRecord::DELETED_TEXT ) {
          Severity: Major
          Found in includes/api/ApiQueryUserContribs.php - About 3 hrs to fix

            Consider simplifying this complex logical expression.
            Open

                        if ( ( isset( $show['minor'] ) && isset( $show['!minor'] ) )
                || ( isset( $show['patrolled'] ) && isset( $show['!patrolled'] ) )
                || ( isset( $show['autopatrolled'] ) && isset( $show['!autopatrolled'] ) )
                || ( isset( $show['autopatrolled'] ) && isset( $show['!patrolled'] ) )
                || ( isset( $show['top'] ) && isset( $show['!top'] ) )
            Severity: Critical
            Found in includes/api/ApiQueryUserContribs.php - About 2 hrs to fix

              Consider simplifying this complex logical expression.
              Open

                      if ( isset( $show['patrolled'] ) || isset( $show['!patrolled'] ) ||
            isset( $show['autopatrolled'] ) || isset( $show['!autopatrolled'] ) || $this->fld_patrolled
        ) {
            $user = $this->getUser();
            if ( !$user->useRCPatrol() && !$user->useNPPatrol() ) {
              Severity: Critical
              Found in includes/api/ApiQueryUserContribs.php - About 1 hr to fix

                Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        ApiQuery $query,
        $moduleName,
        CommentStore $commentStore,
        UserIdentityLookup $userIdentityLookup,
        UserNameUtils $userNameUtils,
                Severity: Major
                Found in includes/api/ApiQueryUserContribs.php - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function __construct(
        ApiQuery $query,
        $moduleName,
        CommentStore $commentStore,
        UserIdentityLookup $userIdentityLookup,
                  Severity: Major
                  Found in includes/api/ApiQueryUserContribs.php and 1 other location - About 3 hrs to fix
                  includes/api/ApiQueryWatchlist.php on lines 62..81

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 143.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if ( ( isset( $show['minor'] ) && isset( $show['!minor'] ) )
                || ( isset( $show['patrolled'] ) && isset( $show['!patrolled'] ) )
                || ( isset( $show['autopatrolled'] ) && isset( $show['!autopatrolled'] ) )
                || ( isset( $show['autopatrolled'] ) && isset( $show['!patrolled'] ) )
                || ( isset( $show['top'] ) && isset( $show['!top'] ) )
                  Severity: Major
                  Found in includes/api/ApiQueryUserContribs.php and 1 other location - About 1 hr to fix
                  includes/api/ApiQueryRecentChanges.php on lines 182..187

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 117.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status