Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/api/ApiQueryWatchlist.php

Summary

Maintainability
F
5 days
Test Coverage

Function extractOutputData has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

    private function extractOutputData( WatchedItem $watchedItem, array $recentChangeInfo ) {
        /* Determine the title of the page that has been changed. */
        $target = $watchedItem->getTarget();
        if ( $target instanceof LinkTarget ) {
            $title = Title::newFromLinkTarget( $target );
Severity: Minor
Found in includes/api/ApiQueryWatchlist.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function run has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

    private function run( $resultPageSet = null ) {
        $params = $this->extractRequestParams();

        $user = $this->getUser();
        $wlowner = $this->getWatchlistUser( $params );
Severity: Minor
Found in includes/api/ApiQueryWatchlist.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ApiQueryWatchlist.php has 481 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Copyright © 2006 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
 *
 * This program is free software; you can redistribute it and/or modify
Severity: Minor
Found in includes/api/ApiQueryWatchlist.php - About 7 hrs to fix

    Method extractOutputData has 134 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function extractOutputData( WatchedItem $watchedItem, array $recentChangeInfo ) {
        /* Determine the title of the page that has been changed. */
        $target = $watchedItem->getTarget();
        if ( $target instanceof LinkTarget ) {
            $title = Title::newFromLinkTarget( $target );
    Severity: Major
    Found in includes/api/ApiQueryWatchlist.php - About 5 hrs to fix

      Method run has 127 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function run( $resultPageSet = null ) {
        $params = $this->extractRequestParams();

        $user = $this->getUser();
        $wlowner = $this->getWatchlistUser( $params );
      Severity: Major
      Found in includes/api/ApiQueryWatchlist.php - About 5 hrs to fix

        Method getAllowedParams has 95 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getAllowedParams() {
        return [
            'allrev' => false,
            'start' => [
                ParamValidator::PARAM_TYPE => 'timestamp'
        Severity: Major
        Found in includes/api/ApiQueryWatchlist.php - About 3 hrs to fix

          Function showParamsConflicting has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              private function showParamsConflicting( array $show ) {
        return ( isset( $show[WatchedItemQueryService::FILTER_MINOR] )
            && isset( $show[WatchedItemQueryService::FILTER_NOT_MINOR] ) )
        || ( isset( $show[WatchedItemQueryService::FILTER_BOT] )
            && isset( $show[WatchedItemQueryService::FILTER_NOT_BOT] ) )
          Severity: Minor
          Found in includes/api/ApiQueryWatchlist.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  ApiQuery $query,
        $moduleName,
        CommentStore $commentStore,
        WatchedItemQueryService $watchedItemQueryService,
        Language $contentLanguage,
          Severity: Major
          Found in includes/api/ApiQueryWatchlist.php - About 1 hr to fix

            Method getFieldsToInclude has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function getFieldsToInclude() {
        $includeFields = [];
        if ( $this->fld_flags ) {
            $includeFields[] = WatchedItemQueryService::INCLUDE_FLAGS;
        }
            Severity: Minor
            Found in includes/api/ApiQueryWatchlist.php - About 1 hr to fix

              Function getFieldsToInclude has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function getFieldsToInclude() {
        $includeFields = [];
        if ( $this->fld_flags ) {
            $includeFields[] = WatchedItemQueryService::INCLUDE_FLAGS;
        }
              Severity: Minor
              Found in includes/api/ApiQueryWatchlist.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function __construct(
        ApiQuery $query,
        $moduleName,
        CommentStore $commentStore,
        WatchedItemQueryService $watchedItemQueryService,
              Severity: Major
              Found in includes/api/ApiQueryWatchlist.php and 1 other location - About 3 hrs to fix
              includes/api/ApiQueryUserContribs.php on lines 69..88

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 143.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status