wikimedia/mediawiki-core

View on GitHub
includes/auth/AuthenticationRequest.php

Summary

Maintainability
D
2 days
Test Coverage

Function mergeFieldInfo has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    public static function mergeFieldInfo( array $reqs ) {
        $merged = [];

        // fields that are required by some primary providers but not others are not actually required
        $sharedRequiredPrimaryFields = null;
Severity: Minor
Found in includes/auth/AuthenticationRequest.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function loadFromSubmission has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    public function loadFromSubmission( array $data ) {
        $fields = array_filter( $this->getFieldInfo(), static function ( $info ) {
            return $info['type'] !== 'null';
        } );
        if ( !$fields ) {
Severity: Minor
Found in includes/auth/AuthenticationRequest.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method mergeFieldInfo has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function mergeFieldInfo( array $reqs ) {
        $merged = [];

        // fields that are required by some primary providers but not others are not actually required
        $sharedRequiredPrimaryFields = null;
Severity: Major
Found in includes/auth/AuthenticationRequest.php - About 2 hrs to fix

    Method loadFromSubmission has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function loadFromSubmission( array $data ) {
            $fields = array_filter( $this->getFieldInfo(), static function ( $info ) {
                return $info['type'] !== 'null';
            } );
            if ( !$fields ) {
    Severity: Minor
    Found in includes/auth/AuthenticationRequest.php - About 1 hr to fix

      Function getUsernameFromRequests has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getUsernameFromRequests( array $reqs ) {
              $username = null;
              $otherClass = null;
              foreach ( $reqs as $req ) {
                  $info = $req->getFieldInfo();
      Severity: Minor
      Found in includes/auth/AuthenticationRequest.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                                  return false;
      Severity: Major
      Found in includes/auth/AuthenticationRequest.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                    return false;
        Severity: Major
        Found in includes/auth/AuthenticationRequest.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in includes/auth/AuthenticationRequest.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return false;
            Severity: Major
            Found in includes/auth/AuthenticationRequest.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status