Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/auth/LocalPasswordPrimaryAuthenticationProvider.php

Summary

Maintainability
C
1 day
Test Coverage

Function providerAllowsAuthenticationDataChange has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function providerAllowsAuthenticationDataChange(
        AuthenticationRequest $req, $checkData = true
    ) {
        // We only want to blank the password if something else will accept the
        // new authentication data, so return 'ignore' here.
Severity: Minor
Found in includes/auth/LocalPasswordPrimaryAuthenticationProvider.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method beginPrimaryAuthentication has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function beginPrimaryAuthentication( array $reqs ) {
        $req = AuthenticationRequest::getRequestByClass( $reqs, PasswordAuthenticationRequest::class );
        if ( !$req || $req->username === null || $req->password === null ) {
            return AuthenticationResponse::newAbstain();
        }
Severity: Major
Found in includes/auth/LocalPasswordPrimaryAuthenticationProvider.php - About 2 hrs to fix

    Function beginPrimaryAuthentication has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function beginPrimaryAuthentication( array $reqs ) {
        $req = AuthenticationRequest::getRequestByClass( $reqs, PasswordAuthenticationRequest::class );
        if ( !$req || $req->username === null || $req->password === null ) {
            return AuthenticationResponse::newAbstain();
        }
    Severity: Minor
    Found in includes/auth/LocalPasswordPrimaryAuthenticationProvider.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method providerAllowsAuthenticationDataChange has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function providerAllowsAuthenticationDataChange(
        AuthenticationRequest $req, $checkData = true
    ) {
        // We only want to blank the password if something else will accept the
        // new authentication data, so return 'ignore' here.
    Severity: Minor
    Found in includes/auth/LocalPasswordPrimaryAuthenticationProvider.php - About 1 hr to fix

      Method providerChangeAuthenticationData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function providerChangeAuthenticationData( AuthenticationRequest $req ) {
        $username = $req->username !== null ?
            $this->userNameUtils->getCanonical( $req->username, UserRigorOptions::RIGOR_USABLE )
            : false;
        if ( $username === false ) {
      Severity: Minor
      Found in includes/auth/LocalPasswordPrimaryAuthenticationProvider.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return AuthenticationResponse::newPass( $username );
        Severity: Major
        Found in includes/auth/LocalPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return $this->failResponse( $req );
          Severity: Major
          Found in includes/auth/LocalPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $this->failResponse( $req );
            Severity: Major
            Found in includes/auth/LocalPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

              Function providerChangeAuthenticationData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function providerChangeAuthenticationData( AuthenticationRequest $req ) {
        $username = $req->username !== null ?
            $this->userNameUtils->getCanonical( $req->username, UserRigorOptions::RIGOR_USABLE )
            : false;
        if ( $username === false ) {
              Severity: Minor
              Found in includes/auth/LocalPasswordPrimaryAuthenticationProvider.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function testUserExists( $username, $flags = IDBAccessObject::READ_NORMAL ) {
        $username = $this->userNameUtils->getCanonical(
            $username, UserRigorOptions::RIGOR_USABLE );
        if ( $username === false ) {
            return false;
              Severity: Major
              Found in includes/auth/LocalPasswordPrimaryAuthenticationProvider.php and 1 other location - About 2 hrs to fix
              includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php on lines 205..218

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 126.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status