wikimedia/mediawiki-core

View on GitHub
includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php

Summary

Maintainability
D
2 days
Test Coverage

File TemporaryPasswordPrimaryAuthenticationProvider.php has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 4 hrs to fix

    Function providerAllowsAuthenticationDataChange has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        public function providerAllowsAuthenticationDataChange(
            AuthenticationRequest $req, $checkData = true
        ) {
            if ( get_class( $req ) !== TemporaryPasswordAuthenticationRequest::class ) {
                // We don't really ignore it, but this is what the caller expects.
    Severity: Minor
    Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method providerAllowsAuthenticationDataChange has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function providerAllowsAuthenticationDataChange(
            AuthenticationRequest $req, $checkData = true
        ) {
            if ( get_class( $req ) !== TemporaryPasswordAuthenticationRequest::class ) {
                // We don't really ignore it, but this is what the caller expects.
    Severity: Minor
    Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 1 hr to fix

      Method beginPrimaryAuthentication has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function beginPrimaryAuthentication( array $reqs ) {
              $req = AuthenticationRequest::getRequestByClass( $reqs, PasswordAuthenticationRequest::class );
              if ( !$req || $req->username === null || $req->password === null ) {
                  return AuthenticationResponse::newAbstain();
              }
      Severity: Minor
      Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 1 hr to fix

        Method providerChangeAuthenticationData has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function providerChangeAuthenticationData( AuthenticationRequest $req ) {
                $username = $req->username !== null ?
                    $this->userNameUtils->getCanonical( $req->username, UserRigorOptions::RIGOR_USABLE ) : false;
                if ( $username === false ) {
                    return;
        Severity: Minor
        Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 1 hr to fix

          Method sendPasswordResetEmail has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function sendPasswordResetEmail( TemporaryPasswordAuthenticationRequest $req ) {
                  $user = User::newFromName( $req->username );
                  if ( !$user ) {
                      return \MediaWiki\Status\Status::newFatal( 'noname' );
                  }
          Severity: Minor
          Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 1 hr to fix

            Function testForAccountCreation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function testForAccountCreation( $user, $creator, array $reqs ) {
                    /** @var TemporaryPasswordAuthenticationRequest $req */
                    $req = AuthenticationRequest::getRequestByClass(
                        $reqs, TemporaryPasswordAuthenticationRequest::class
                    );
            Severity: Minor
            Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                                    return \StatusValue::newFatal( 'passwordreset-nosuchcaller', $req->caller );
            Severity: Major
            Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $this->failResponse( $req );
              Severity: Major
              Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return \StatusValue::newFatal( 'throttled-mailpassword',
                                        round( $this->passwordReminderResendTime, 3 ) );
                Severity: Major
                Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return [];
                  Severity: Major
                  Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return \StatusValue::newFatal( 'passwordreset-nocaller' );
                    Severity: Major
                    Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return AuthenticationResponse::newPass( $username );
                      Severity: Major
                      Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return [ new TemporaryPasswordAuthenticationRequest ];
                        Severity: Major
                        Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                              return \StatusValue::newFatal( 'passwordreset-emaildisabled' );
                          Severity: Major
                          Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return $sv;
                            Severity: Major
                            Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 30 mins to fix

                              Function beginPrimaryAuthentication has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function beginPrimaryAuthentication( array $reqs ) {
                                      $req = AuthenticationRequest::getRequestByClass( $reqs, PasswordAuthenticationRequest::class );
                                      if ( !$req || $req->username === null || $req->password === null ) {
                                          return AuthenticationResponse::newAbstain();
                                      }
                              Severity: Minor
                              Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function beginPrimaryAccountCreation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function beginPrimaryAccountCreation( $user, $creator, array $reqs ) {
                                      /** @var TemporaryPasswordAuthenticationRequest $req */
                                      $req = AuthenticationRequest::getRequestByClass(
                                          $reqs, TemporaryPasswordAuthenticationRequest::class
                                      );
                              Severity: Minor
                              Found in includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  public function testUserExists( $username, $flags = IDBAccessObject::READ_NORMAL ) {
                                      $username = $this->userNameUtils->getCanonical( $username, UserRigorOptions::RIGOR_USABLE );
                                      if ( $username === false ) {
                                          return false;
                                      }
                              includes/auth/LocalPasswordPrimaryAuthenticationProvider.php on lines 186..200

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 126.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status