Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/changes/EnhancedChangesList.php

Summary

Maintainability
F
6 days
Test Coverage

File EnhancedChangesList.php has 592 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

use MediaWiki\Context\IContextSource;
use MediaWiki\Html\Html;
use MediaWiki\Html\TemplateParser;
Severity: Major
Found in includes/changes/EnhancedChangesList.php - About 1 day to fix

    Function recentChangesBlockGroup has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function recentChangesBlockGroup( $block ) {
        $recentChangesFlags = $this->getConfig()->get( MainConfigNames::RecentChangesFlags );

        # Add the namespace and title of the block as part of the class
        $tableClasses = [ 'mw-enhanced-rc', 'mw-changeslist-line' ];
    Severity: Minor
    Found in includes/changes/EnhancedChangesList.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method recentChangesBlockGroup has 163 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function recentChangesBlockGroup( $block ) {
        $recentChangesFlags = $this->getConfig()->get( MainConfigNames::RecentChangesFlags );

        # Add the namespace and title of the block as part of the class
        $tableClasses = [ 'mw-enhanced-rc', 'mw-changeslist-line' ];
    Severity: Major
    Found in includes/changes/EnhancedChangesList.php - About 6 hrs to fix

      Method recentChangesBlockLine has 105 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function recentChangesBlockLine( $rcObj ) {
        $data = [];

        $type = $rcObj->mAttribs['rc_type'];
        $logType = $rcObj->mAttribs['rc_log_type'];
      Severity: Major
      Found in includes/changes/EnhancedChangesList.php - About 4 hrs to fix

        Function getLogText has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function getLogText( $block, $queryParams, $allLogs, $isnew, $namehidden ) {
        if ( !$block ) {
            return '';
        }
        Severity: Minor
        Found in includes/changes/EnhancedChangesList.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getLineData has 99 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function getLineData( array $block, RCCacheEntry $rcObj, array $queryParams = [] ) {
        $RCShowChangedSize = $this->getConfig()->get( MainConfigNames::RCShowChangedSize );

        $type = $rcObj->mAttribs['rc_type'];
        $data = [];
        Severity: Major
        Found in includes/changes/EnhancedChangesList.php - About 3 hrs to fix

          Method getLogText has 97 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function getLogText( $block, $queryParams, $allLogs, $isnew, $namehidden ) {
        if ( !$block ) {
            return '';
        }
          Severity: Major
          Found in includes/changes/EnhancedChangesList.php - About 3 hrs to fix

            Function getLineData has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function getLineData( array $block, RCCacheEntry $rcObj, array $queryParams = [] ) {
        $RCShowChangedSize = $this->getConfig()->get( MainConfigNames::RCShowChangedSize );

        $type = $rcObj->mAttribs['rc_type'];
        $data = [];
            Severity: Minor
            Found in includes/changes/EnhancedChangesList.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function recentChangesBlockLine has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function recentChangesBlockLine( $rcObj ) {
        $data = [];

        $type = $rcObj->mAttribs['rc_type'];
        $logType = $rcObj->mAttribs['rc_log_type'];
            Severity: Minor
            Found in includes/changes/EnhancedChangesList.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getDiffHistLinks has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getDiffHistLinks( RCCacheEntry $rc, $query = null, $useParentheses = null ) {
        if ( is_bool( $query ) ) {
            $useParentheses = $query;
        } elseif ( $query !== null ) {
            wfDeprecated( __METHOD__ . ' with $query parameter', '1.36' );
            Severity: Minor
            Found in includes/changes/EnhancedChangesList.php - About 1 hr to fix

              Method getLogText has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  protected function getLogText( $block, $queryParams, $allLogs, $isnew, $namehidden ) {
              Severity: Minor
              Found in includes/changes/EnhancedChangesList.php - About 35 mins to fix

                Function getDiffHistLinks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getDiffHistLinks( RCCacheEntry $rc, $query = null, $useParentheses = null ) {
        if ( is_bool( $query ) ) {
            $useParentheses = $query;
        } elseif ( $query !== null ) {
            wfDeprecated( __METHOD__ . ' with $query parameter', '1.36' );
                Severity: Minor
                Found in includes/changes/EnhancedChangesList.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function recentChangesBlock has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function recentChangesBlock() {
        if ( count( $this->rc_cache ) == 0 ) {
            return '';
        }
                Severity: Minor
                Found in includes/changes/EnhancedChangesList.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( $type == RC_LOG ) {
            $data['logEntry'] = $this->insertLogEntry( $rcObj );
        } elseif ( $this->isCategorizationWithoutRevision( $rcObj ) ) {
            $data['comment'] = $this->insertComment( $rcObj );
        } else {
                Severity: Major
                Found in includes/changes/EnhancedChangesList.php and 1 other location - About 3 hrs to fix
                includes/changes/EnhancedChangesList.php on lines 422..436

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 154.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( $type == RC_LOG ) {
            $data['logEntry'] = $this->insertLogEntry( $rcObj );
        } elseif ( $this->isCategorizationWithoutRevision( $rcObj ) ) {
            $data['comment'] = $this->insertComment( $rcObj );
        } else {
                Severity: Major
                Found in includes/changes/EnhancedChangesList.php and 1 other location - About 3 hrs to fix
                includes/changes/EnhancedChangesList.php on lines 670..682

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 154.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status