Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/collation/IcuCollation.php

Summary

Maintainability
C
1 day
Test Coverage

File IcuCollation.php has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/collation/IcuCollation.php - About 3 hrs to fix

    Function fetchFirstLetterData has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        private function fetchFirstLetterData() {
        // Generate data from serialized data file
        if ( isset( self::TAILORING_FIRST_LETTERS[$this->locale] ) ) {
            $letters = require __DIR__ . "/data/first-letters-root.php";
            // Append additional characters
    Severity: Minor
    Found in includes/collation/IcuCollation.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fetchFirstLetterData has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function fetchFirstLetterData() {
        // Generate data from serialized data file
        if ( isset( self::TAILORING_FIRST_LETTERS[$this->locale] ) ) {
            $letters = require __DIR__ . "/data/first-letters-root.php";
            // Append additional characters
    Severity: Major
    Found in includes/collation/IcuCollation.php - About 2 hrs to fix

      Method getFirstLetter has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getFirstLetter( $string ) {
        $string = strval( $string );
        if ( $string === '' ) {
            return '';
        }
      Severity: Minor
      Found in includes/collation/IcuCollation.php - About 1 hr to fix

        Function getFirstLetter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getFirstLetter( $string ) {
        $string = strval( $string );
        if ( $string === '' ) {
            return '';
        }
        Severity: Minor
        Found in includes/collation/IcuCollation.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return $sortLetter;
        Severity: Major
        Found in includes/collation/IcuCollation.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status