Method load
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function load() {
if ( $this->procCache !== null ) {
return; // already loaded
}
Function load
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
private function load() {
if ( $this->procCache !== null ) {
return; // already loaded
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __construct( array $params ) {
$params += [
'service' => 'etcd',
'port' => null,
'protocol' => 'http',
Function parseDirectory
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function parseDirectory( $dirName, $dirNode, &$config ) {
$lastModifiedIndex = 0;
if ( !isset( $dirNode['nodes'] ) ) {
throw new EtcdConfigParseError(
"Unexpected JSON response in dir '$dirName'; missing 'nodes' list." );
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parseDirectory
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function parseDirectory( $dirName, $dirNode, &$config ) {
$lastModifiedIndex = 0;
if ( !isset( $dirNode['nodes'] ) ) {
throw new EtcdConfigParseError(
"Unexpected JSON response in dir '$dirName'; missing 'nodes' list." );
Function __construct
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function __construct( array $params ) {
$params += [
'service' => 'etcd',
'port' => null,
'protocol' => 'http',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return WaitConditionLoop::CONDITION_CONTINUE;
Avoid too many return
statements within this method. Open
return WaitConditionLoop::CONDITION_REACHED;