Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/context/RequestContext.php

Summary

Maintainability
D
2 days
Test Coverage

File RequestContext.php has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/context/RequestContext.php - About 5 hrs to fix

    RequestContext has 38 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class RequestContext implements IContextSource, MutableContext {
    use NonSerializableTrait;

    /**
     * @var WebRequest
    Severity: Minor
    Found in includes/context/RequestContext.php - About 5 hrs to fix

      Method importScopedSession has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function importScopedSession( array $params ) {
        if ( strlen( $params['sessionId'] ) &&
            SessionManager::getGlobalSession()->isPersistent()
        ) {
            // Check to avoid sending random cookies for the wrong users.
      Severity: Major
      Found in includes/context/RequestContext.php - About 2 hrs to fix

        Function importScopedSession has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function importScopedSession( array $params ) {
        if ( strlen( $params['sessionId'] ) &&
            SessionManager::getGlobalSession()->isPersistent()
        ) {
            // Check to avoid sending random cookies for the wrong users.
        Severity: Minor
        Found in includes/context/RequestContext.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getLanguage has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getLanguage() {
        if ( $this->languageRecursion === true ) {
            throw new LogicException( 'Recursion detected' );
        }
        Severity: Minor
        Found in includes/context/RequestContext.php - About 1 hr to fix

          Function getLanguage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getLanguage() {
        if ( $this->languageRecursion === true ) {
            throw new LogicException( 'Recursion detected' );
        }
          Severity: Minor
          Found in includes/context/RequestContext.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status