Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/deferred/DeferredUpdates.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method doUpdates has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function doUpdates( $stage = self::ALL ) {
        /** @var ErrorPageError $guiError First presentable client-level error thrown */
        $guiError = null;
        /** @var Throwable $exception First of any error thrown */
        $exception = null;
Severity: Minor
Found in includes/deferred/DeferredUpdates.php - About 1 hr to fix

    Method run has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function run( DeferrableUpdate $update ): ?Throwable {
        $logger = LoggerFactory::getInstance( 'DeferredUpdates' );

        $type = get_class( $update )
            . ( $update instanceof DeferrableCallback ? '_' . $update->getOrigin() : '' );
    Severity: Minor
    Found in includes/deferred/DeferredUpdates.php - About 1 hr to fix

      Method tryOpportunisticExecute has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function tryOpportunisticExecute(): bool {
        // Leave execution up to the current loop if an update is already in progress
        // or if updates are explicitly disabled
        if ( self::getRecursiveExecutionStackDepth()
            || self::$preventOpportunisticUpdates
      Severity: Minor
      Found in includes/deferred/DeferredUpdates.php - About 1 hr to fix

        Function doUpdates has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function doUpdates( $stage = self::ALL ) {
        /** @var ErrorPageError $guiError First presentable client-level error thrown */
        $guiError = null;
        /** @var Throwable $exception First of any error thrown */
        $exception = null;
        Severity: Minor
        Found in includes/deferred/DeferredUpdates.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function run( DeferrableUpdate $update ): ?Throwable {
        $logger = LoggerFactory::getInstance( 'DeferredUpdates' );

        $type = get_class( $update )
            . ( $update instanceof DeferrableCallback ? '_' . $update->getOrigin() : '' );
        Severity: Minor
        Found in includes/deferred/DeferredUpdates.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function tryOpportunisticExecute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function tryOpportunisticExecute(): bool {
        // Leave execution up to the current loop if an update is already in progress
        // or if updates are explicitly disabled
        if ( self::getRecursiveExecutionStackDepth()
            || self::$preventOpportunisticUpdates
        Severity: Minor
        Found in includes/deferred/DeferredUpdates.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status