Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/deferred/DeferredUpdatesScopeMediaWikiStack.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method onRunUpdateStart has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function onRunUpdateStart( DeferrableUpdate $update ): void {
        // Increment a counter metric
        $type = get_class( $update )
            . ( $update instanceof DeferrableCallback ? '_' . $update->getOrigin() : '' );
        $httpMethod = MW_ENTRY_POINT === 'cli' ? 'cli' : strtolower( $_SERVER['REQUEST_METHOD'] ?? 'GET' );
Severity: Minor
Found in includes/deferred/DeferredUpdatesScopeMediaWikiStack.php - About 1 hr to fix

    Function areDatabaseTransactionsActive has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function areDatabaseTransactionsActive(): bool {
        $lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
        if ( $lbFactory->hasTransactionRound()
            || !$lbFactory->isReadyForRoundOperations()
        ) {
    Severity: Minor
    Found in includes/deferred/DeferredUpdatesScopeMediaWikiStack.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onRunUpdateStart has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function onRunUpdateStart( DeferrableUpdate $update ): void {
        // Increment a counter metric
        $type = get_class( $update )
            . ( $update instanceof DeferrableCallback ? '_' . $update->getOrigin() : '' );
        $httpMethod = MW_ENTRY_POINT === 'cli' ? 'cli' : strtolower( $_SERVER['REQUEST_METHOD'] ?? 'GET' );
    Severity: Minor
    Found in includes/deferred/DeferredUpdatesScopeMediaWikiStack.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status