Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/deferred/LinksUpdate/CategoryLinksTable.php

Summary

Maintainability
B
6 hrs
Test Coverage

CategoryLinksTable has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class CategoryLinksTable extends TitleLinksTable {
    /**
     * @var array Associative array of new links, with the category name in the
     *   key. The value is a list consisting of the sort key prefix and the sort
     *   key.
Severity: Minor
Found in includes/deferred/LinksUpdate/CategoryLinksTable.php - About 2 hrs to fix

    Function updateCategoryCounts has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        private function updateCategoryCounts( array $insertedLinks, array $deletedLinks ) {
        if ( !$insertedLinks && !$deletedLinks ) {
            return;
        }
    Severity: Minor
    Found in includes/deferred/LinksUpdate/CategoryLinksTable.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method updateCategoryCounts has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function updateCategoryCounts( array $insertedLinks, array $deletedLinks ) {
        if ( !$insertedLinks && !$deletedLinks ) {
            return;
        }
    Severity: Minor
    Found in includes/deferred/LinksUpdate/CategoryLinksTable.php - About 1 hr to fix

      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              LanguageConverterFactory $converterFactory,
        NamespaceInfo $namespaceInfo,
        WikiPageFactory $wikiPageFactory,
        Collation $collation,
        $collationName,
      Severity: Major
      Found in includes/deferred/LinksUpdate/CategoryLinksTable.php - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status