Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/editpage/PreloadedContentBuilder.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method getPreloadedContentFromParams has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getPreloadedContentFromParams(
        ProperPageIdentity $contextPage,
        Authority $performer,
        ?string $preload,
        array $preloadParams
Severity: Major
Found in includes/editpage/PreloadedContentBuilder.php - About 2 hrs to fix

    Function getPreloadedContentFromParams has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getPreloadedContentFromParams(
        ProperPageIdentity $contextPage,
        Authority $performer,
        ?string $preload,
        array $preloadParams
    Severity: Minor
    Found in includes/editpage/PreloadedContentBuilder.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            IContentHandlerFactory $contentHandlerFactory,
        WikiPageFactory $wikiPageFactory,
        RedirectLookup $redirectLookup,
        SpecialPageFactory $specialPageFactory,
        ContentTransformer $contentTransformer,
    Severity: Minor
    Found in includes/editpage/PreloadedContentBuilder.php - About 45 mins to fix

      Method getPreloadedContent has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ProperPageIdentity $page,
        Authority $performer,
        ?string $preload,
        array $preloadParams,
        ?string $section
      Severity: Minor
      Found in includes/editpage/PreloadedContentBuilder.php - About 35 mins to fix

        Function getPreloadedContent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getPreloadedContent(
        ProperPageIdentity $page,
        Authority $performer,
        ?string $preload,
        array $preloadParams,
        Severity: Minor
        Found in includes/editpage/PreloadedContentBuilder.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return $this->transform( $content, $title, $preloadParams );
        Severity: Major
        Found in includes/editpage/PreloadedContentBuilder.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $handler->makeEmptyContent();
          Severity: Major
          Found in includes/editpage/PreloadedContentBuilder.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $handler->makeEmptyContent();
            Severity: Major
            Found in includes/editpage/PreloadedContentBuilder.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $handler->makeEmptyContent();
              Severity: Major
              Found in includes/editpage/PreloadedContentBuilder.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status